Skip to content

Commit c0e94a2

Browse files
authored
Merge pull request #206 from sendbird/chore/remove-allSettled
chore: remove Promise.allSettled
2 parents 7513d04 + 631077d commit c0e94a2

File tree

5 files changed

+18
-8
lines changed

5 files changed

+18
-8
lines changed

packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,8 @@ const SendInput = forwardRef<RNTextInput, SendInputProps>(function SendInput(
216216
onClose={onClose}
217217
onDismiss={() => {
218218
onDismiss();
219-
Promise.allSettled([playerService.reset(), recorderService.reset()]);
219+
playerService.reset().catch(() => {});
220+
recorderService.reset().catch(() => {});
220221
}}
221222
backgroundStyle={{ justifyContent: 'flex-end' }}
222223
visible={voiceMessageInputVisible}

packages/uikit-react-native/src/contexts/PlatformServiceCtx.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ export const PlatformServiceProvider = ({ children, voiceMessageConfig, ...servi
3131

3232
useAppState('change', (state) => {
3333
if (state !== 'active') {
34-
Promise.allSettled([services.playerService.reset(), services.recorderService.reset()]);
34+
services.playerService.reset().catch(() => {});
35+
services.recorderService.reset().catch(() => {});
3536
}
3637
});
3738

packages/uikit-react-native/src/fragments/createGroupChannelFragment.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,9 @@ const createGroupChannelFragment = (initModule?: Partial<GroupChannelModule>): G
116116
startingPoint: internalSearchItem?.startingPoint,
117117
});
118118

119-
const onBlurFragment = () => {
120-
return Promise.allSettled([playerService.reset(), recorderService.reset()]);
119+
const onBlurFragment = async () => {
120+
await playerService.reset().catch(() => {});
121+
await recorderService.reset().catch(() => {});
121122
};
122123
const _onPressHeaderLeft = useFreshCallback(async () => {
123124
voiceMessageStatusManager.clear();

packages/uikit-react-native/src/fragments/createGroupChannelThreadFragment.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ const createGroupChannelThreadFragment = (
103103
startingPoint,
104104
});
105105

106-
const onBlurFragment = () => {
107-
return Promise.allSettled([playerService.reset(), recorderService.reset()]);
106+
const onBlurFragment = async () => {
107+
await playerService.reset().catch(() => {});
108+
await recorderService.reset().catch(() => {});
108109
};
109110
const _onPressHeaderLeft = useFreshCallback(async () => {
110111
await onBlurFragment();

packages/uikit-react-native/src/hooks/useConnection.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,10 @@ const useConnection = () => {
5252
});
5353
}
5454

55-
await Promise.allSettled([initEmoji(sdk, emojiManager), initDashboardConfigs(sdk)]);
55+
await Promise.all([
56+
initEmoji(sdk, emojiManager).catch(() => Logger.info('[useConnection]', 'initEmoji failure')),
57+
initDashboardConfigs(sdk).catch(() => Logger.info('[useConnection]', 'initDashboardConfigs failure')),
58+
]);
5659

5760
Logger.debug('[useConnection]', 'connected! (online)');
5861
setCurrentUser(user);
@@ -67,7 +70,10 @@ const useConnection = () => {
6770
Logger.warn('[useConnection]', 'clear cached-data');
6871
await sdk.clearCachedData().catch((e) => Logger.warn('[useConnection]', 'clear cached-data failure', e));
6972
} else if (sdk.currentUser) {
70-
await Promise.allSettled([initEmoji(sdk, emojiManager), initDashboardConfigs(sdk)]);
73+
await Promise.all([
74+
initEmoji(sdk, emojiManager).catch(() => Logger.info('[useConnection]', 'initEmoji failure')),
75+
initDashboardConfigs(sdk).catch(() => Logger.info('[useConnection]', 'initDashboardConfigs failure')),
76+
]);
7177

7278
Logger.debug('[useConnection]', 'connected! (offline)');
7379
setCurrentUser(sdk.currentUser);

0 commit comments

Comments
 (0)