Skip to content

golines does not shorten index expressions in declarations #128

@bgimby

Description

@bgimby

golines will shorten a declaration like this:

foo := longlistfunc(bigarg, otherbigarg, verylongarg, veryverylongarg, veryveryverylongarg, extremelylongarg)

to

foo := longlistfunc(
	bigarg,
	otherbigarg,
	verylongarg,
	veryverylongarg,
	veryveryverylongarg,
	extremelylongarg,
)

I would expect it to similarly shorten a declaration like

foo := longlistfunc(bigarg, otherbigarg, verylongarg, veryverylongarg, veryveryverylongarg, extremelylongarg)[0]

to

foo := longlistfunc(
	bigarg,
	otherbigarg,
	verylongarg,
	veryverylongarg,
	veryveryverylongarg,
	extremelylongarg,
)[0]

but it is left alone. This appears to be due to formatExpr not supporting index expressions. It results in a debug message like

Got an expression type that can't be shortened: *dst.IndexExpr

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions