Skip to content

Commit 2a89693

Browse files
AnkitSegmentpaco-walkmevaradarajan-twGhassenRjab
authored
[STAGE] Stratconn-2841 (#772)
* [Walkme] Add option to choose a custom bucket (#759) * Add option to choose a custom bucket --------- Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> * bump walkme integration version to 1.2.0 (#768) * fixes typo and related test (#771) * fixes typo and related test some test were returning false positive, update the way to check on them * bump package version to 1.2.1 --------- Co-authored-by: Varadarajan V <[email protected]> * Support for SystemJS in MadKudu integration (#765) * UMD need window.require * Update version * STRATCONN-2841 added msgid as event id in propertyMap Added this property to test on stage branch * updating version * resolve conflit --------- Co-authored-by: paco-walkme <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Varadarajan V <[email protected]> Co-authored-by: Ghassen Rjab <[email protected]>
1 parent 89869fd commit 2a89693

File tree

7 files changed

+22
-10
lines changed

7 files changed

+22
-10
lines changed

Diff for: integrations/madkudu/lib/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var integration = require('@segment/analytics.js-integration');
1010
* UMD?
1111
*/
1212

13-
var umd = typeof window.define === 'function' && window.define.amd;
13+
var umd = typeof window.define === 'function' && window.define.amd && window.require;
1414

1515
/**
1616
* Expose `Madkudu` integration.

Diff for: integrations/madkudu/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-madkudu",
33
"description": "The Madkudu analytics.js integration.",
4-
"version": "2.0.1",
4+
"version": "2.0.2",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

Diff for: integrations/pinterest-tag/lib/index.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,8 @@ Pinterest.prototype.createPropertyMapping = function() {
117117
order_id: 'order_id',
118118
coupon: 'coupon',
119119
value: 'value',
120-
currency: 'currency'
120+
currency: 'currency',
121+
messageId: 'event_id'
121122
};
122123

123124
// This is a second map to allow us to loop over specific potentially-nested properties.
@@ -140,6 +141,8 @@ Pinterest.prototype.createPropertyMapping = function() {
140141

141142
Pinterest.prototype.generatePropertiesObject = function(track) {
142143
// Generate the properties object to send with the call.
144+
console.log({"segmentEvent": segmentEvent, "pinterestEvent": pinterestEvent, "pinterestObject": pinterestObject});
145+
143146
var pinterestProps = {};
144147
var trackValue;
145148
for (var prop in this.propertyMap) {

Diff for: integrations/pinterest-tag/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@segment/analytics.js-integration-pinterest-tag",
33
"description": "The Pinterest Tag analytics.js integration.",
4-
"version": "1.2.3",
4+
"version": "1.2.4",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

Diff for: integrations/walkme/lib/index.js

+13-4
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ WalkMe.prototype.initialize = function() {
4040

4141
var env = (this.options.environment && this.options.environment.toLowerCase());
4242

43-
if (!env || env == "\/" || env == "\/production") {
43+
if (env === "/" || env === "/production") {
4444
env = "";
4545
}
4646

@@ -67,16 +67,25 @@ WalkMe.prototype.initialize = function() {
6767
if (this.options.integrityHash) {
6868
sriSuffix = 'private_';
6969
}
70-
70+
7171
var bucket = (this.options.customDirectory) ? this.options.customDirectory : 'users';
7272
var url = 'https://cdn.walkme.com/' + bucket + '/' + walkMeSystemId + '/' + env + '/walkme_' + sriSuffix + walkMeSystemId + '_https.js';
7373

74-
this.load({
74+
75+
var payload = {
7576
url,
7677
hash: this.options.integrityHash
77-
});
78+
};
79+
80+
this.initializeTester(payload);
81+
this.load(payload);
7882
};
7983

84+
/**
85+
* Used for testing initialization
86+
*/
87+
WalkMe.prototype.initializeTester = function () {};
88+
8089
/**
8190
* Has the WalkMe library been loaded yet?
8291
*

Diff for: integrations/walkme/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@walkme/analytics.js-integration-walkme",
33
"description": "The WalkMe analytics.js integration.",
4-
"version": "1.1.0",
4+
"version": "1.2.1",
55
"keywords": [
66
"analytics.js",
77
"analytics.js-integration",

Diff for: integrations/walkme/test/index.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -238,4 +238,4 @@ describe('WalkMe', function() {
238238
}).timeout(10000);
239239
});
240240
});
241-
});
241+
});

0 commit comments

Comments
 (0)