Merge pull request #269 from North-Two-Five/Issue-268-Raise-Error

Push raising error message

Author: MichaelGHSeg

.github/workflows/gem-push.yml

@@ -15,7 +15,7 @@ jobs:
       packages: write
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

.github/workflows/ruby.yml

@@ -22,7 +22,7 @@ jobs:
         ruby-version: ['2.4', '2.5', '2.6', '2.7', '3.0', '3.1', '3.2']
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

lib/segment/analytics/message_batch.rb

@@ -29,6 +29,7 @@ def <<(message)
         message_json_size = message_json.bytesize
         if message_too_big?(message_json_size)
           logger.error('a message exceeded the maximum allowed size')
+          raise JSONGenerationError, 'Message Exceeded Maximum Allowed Size'
         else
           @messages << message
           @json_size += message_json_size + 1 # One byte for the comma

spec/segment/analytics/message_batch_spec.rb

@@ -9,16 +9,21 @@ class Analytics
 
       describe '#<<' do
         it 'appends messages' do
+          expect(subject.length).to eq(0)
+
           subject << { 'a' => 'b' }
+
           expect(subject.length).to eq(1)
         end
 
         it 'rejects messages that exceed the maximum allowed size' do
           max_bytes = Defaults::Message::MAX_BYTES
           message = { 'a' => 'b' * max_bytes }
 
-          subject << message
           expect(subject.length).to eq(0)
+
+          expect { subject << message }.to raise_error(MessageBatch::JSONGenerationError)
+            .with_message('Message Exceeded Maximum Allowed Size')
         end
       end