Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox attributes in development mode #173

Closed
teleservizi opened this issue Sep 16, 2015 · 1 comment · May be fixed by segment-boneyard/amphtml#3
Closed

Lightbox attributes in development mode #173

teleservizi opened this issue Sep 16, 2015 · 1 comment · May be fixed by segment-boneyard/amphtml#3

Comments

@teleservizi
Copy link

In development mode (< script src="https://www.gstatic.com/amphtml/v0.js" development >< /script >) the console says that my lightbox is missing this attributes : from,width,height.
The first is undocumented and the lightbox works fine even without it
Width and Height are totally ignored even if setted

< amp-lightbox id="mainLightbox3" class="lightbox1" layout="nodisplay" >
.....
< /amp-lightbox >
@cramforce
Copy link
Member

We're slightly surprised the lightbox is working at all :) It isn't in our released set of components. (See release notes). We actually expect major changes to make it much better to land soon.

I will close this for now, but will ping when we released the component.

CC @dvoytenko

@ghost ghost mentioned this issue Sep 16, 2016
Merged
erwinmombay pushed a commit that referenced this issue Sep 16, 2016
@erwinmombay
Add references to layout docs; fixes #173 (#5063)
9873650
@erwinmombay erwinmombay mentioned this issue Sep 26, 2016
Closed
mityaha pushed a commit to ooyala/amphtml that referenced this issue Nov 30, 2016
@mityaha
Add references to layout docs; fixes ampproject#173 (ampproject#5063)
a98daec
@snyk-bot snyk-bot mentioned this issue May 2, 2021
Open
@snyk-bot snyk-bot mentioned this issue Apr 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade document-register-element from 1.1.1 to 1.14.10 segment-boneyard/amphtml
2 participants
@cramforce @teleservizi