Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing context extension in downloaded RO-Crate #576

Closed
simleo opened this issue Apr 21, 2021 · 2 comments
Closed

Missing context extension in downloaded RO-Crate #576

simleo opened this issue Apr 21, 2021 · 2 comments

Comments

@simleo
Copy link

simleo commented Apr 21, 2021

Describe the bug

When a workflow that was uploaded as an RO-Crate is subsequently downloaded as an RO-Crate, the metadata file is missing any context extensions from the original one.

To Reproduce

Upload this crate to WorkflowHub (tested on https://dev.workflowhub.eu), then download it as an RO-Crate.

Details

The above example is a Workflow Testing RO-Crate, which uses context extensions defined in the ro-terms test namespace.

The crate's original context was:

    "@context": [
        "https://w3id.org/ro/crate/1.1/context",
        {
            "GithubService": "https://w3id.org/ro/terms/test#GithubService",
            "JenkinsService": "https://w3id.org/ro/terms/test#JenkinsService",
            "PlanemoEngine": "https://w3id.org/ro/terms/test#PlanemoEngine",
            "TestDefinition": "https://w3id.org/ro/terms/test#TestDefinition",
            "TestInstance": "https://w3id.org/ro/terms/test#TestInstance",
            "TestService": "https://w3id.org/ro/terms/test#TestService",
            "TestSuite": "https://w3id.org/ro/terms/test#TestSuite",
            "TravisService": "https://w3id.org/ro/terms/test#TravisService",
            "definition": "https://w3id.org/ro/terms/test#definition",
            "engineVersion": "https://w3id.org/ro/terms/test#engineVersion",
            "instance": "https://w3id.org/ro/terms/test#instance",
            "resource": "https://w3id.org/ro/terms/test#resource",
            "runsOn": "https://w3id.org/ro/terms/test#runsOn"
        }
    ]

While the context in the downloaded crate is:

    "@context": "https://w3id.org/ro/crate/1.1/context"
@fbacall
Copy link
Contributor

fbacall commented Apr 26, 2021

This is a current limitation of the library, so I've raised an issue in that repository.

Does the python library handle this case?

@simleo
Copy link
Author

simleo commented Apr 27, 2021

This is a current limitation of the library, so I've raised an issue in that repository.

Thanks!

Does the python library handle this case?

There is some initial support, but it's not finished yet. I just opened ResearchObject/ro-crate-py#61 to keep track of what's missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants