code update according to copilot review

Author: whomingbird

app/models/publication.rb

@@ -594,19 +594,19 @@ def check_bibtex_file (bibtex_record)
       return false
     end
 
-    if (['Collection','Conference Paper'].include? self.publication_type.title) && (bibtex_record[:booktitle].blank?)
-      errors.add(:base, "An #{self.publication_type.title} needs to have a booktitle.")
+    if (['Collection', 'Conference Paper'].include? self.publication_type.title) && (bibtex_record[:booktitle].blank?)
+      errors.add(:base, "A #{self.publication_type.title} needs to have a booktitle.")
         return false
     end
 
-    unless ['Booklet','Text','Other','Conference Proceeding'].include? self.publication_type.title
+    unless ['Booklet', 'Text', 'Other', 'Conference Proceeding'].include? self.publication_type.title
       if bibtex_record[:author].nil? && self.editor.nil?
         self.errors.add(:base, "You need at least one author or editor for the #{self.publication_type.title}.")
         return false
       end
     end
 
-    if publication_type.key == 'bachelorsthesis' || publication_type.key == 'mastersthesis' || publication_type.key == 'phdthesis'
+    if ['bachelorsthesis', 'mastersthesis', 'phdthesis', 'diplomthesis'].include?(publication_type.key)
       if bibtex_record[:school].try(:to_s).nil?
         self.errors.add(:base,"A #{self.publication_type.title} needs to have a school.")
         return false

app/models/publication_type.rb

@@ -41,12 +41,18 @@ def self.get_publication_type_id(bibtex_record)
     publication_key = bibtex_record.to_s[/@(.*?)\{/m, 1].to_s.downcase.strip
     datacite_key = BIBTEX_TO_DATACITE_KEY[publication_key] || 'other'
     pub_type = PublicationType.find_by(key: datacite_key)
-    pub_type.id
+    return pub_type.id if pub_type
+    other_type = PublicationType.find_by(key: 'other')
+    other_type&.id
   end
 
-  type_registry.each_key do |title|
-    define_singleton_method(title.gsub(/\s+/, '')) do
-      find_by(key: type_registry[title]['key'])
+  begin
+    type_registry.each_key do |title|
+      define_singleton_method(title.gsub(/\s+/, '')) do
+        find_by(key: type_registry[title]['key'])
+      end
     end
+  rescue => e
+    Rails.logger.error("Failed to load publication types: #{e.message}")
   end
 end

db/seeds/005_publication_types.seeds.rb

@@ -44,11 +44,11 @@
 # -------------------------------------------------------------------
 # STEP 2 — Ensure all DataCite YAML types exist and match
 # -------------------------------------------------------------------
+existing_by_key = PublicationType.all.index_by(&:key)
 expected.values.each do |etype|
   title = etype["title"]
   key   = etype["key"]
-
-  existing = PublicationType.find_by(key: key)
+  existing = existing_by_key[key]
 
   if existing.nil?
     puts "Creating new type: #{title}"

test/functional/publications_controller_test.rb

@@ -300,9 +300,9 @@ def test_title
     assert_difference('Publication.count', 0) do
       post :create, params: { subaction: 'ImportMultiple', publication: { bibtex_file: fixture_file_upload('bibtex/error_bibtex.bib'), project_ids: [projects(:one).id] } }
       assert_redirected_to publications_path
-      assert_includes flash[:error], 'An Conference Paper needs to have a booktitle.'
+      assert_includes flash[:error], 'A Conference Paper needs to have a booktitle.'
       assert_includes flash[:error], 'Please check your bibtex files, each publication should contain a title or a chapter name.'
-      assert_includes flash[:error], 'An Collection needs to have a booktitle.'
+      assert_includes flash[:error], 'A Collection needs to have a booktitle.'
       assert_includes flash[:error], 'A Doctoral Thesis needs to have a school.'
       assert_includes flash[:error], "A Master's Thesis needs to have a school."
       assert_includes flash[:error], 'You need at least one author or editor for the Journal Article.'