From 982b528711a57c68e4875e369e66582b61af0edd Mon Sep 17 00:00:00 2001 From: Robert Haines Date: Tue, 15 Jul 2014 16:02:31 +0100 Subject: [PATCH] Move dependencies to the gemspec and lock down versions. Development dependencies should go in the gemspec when using a Gemfile. Versions are locked down to prevent failures creeping in as dependencies are updated (so long as they play nice with semantic versioning). An example of this is the minitest gem; see issue 164 (https://github.com/rubyzip/rubyzip/issues/164). --- Gemfile | 4 ---- rubyzip.gemspec | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Gemfile b/Gemfile index 7e023e75..fa75df15 100644 --- a/Gemfile +++ b/Gemfile @@ -1,7 +1,3 @@ source 'https://rubygems.org' gemspec -gem 'rake' -gem 'coveralls', :require => false -gem 'pry' -gem 'minitest' diff --git a/rubyzip.gemspec b/rubyzip.gemspec index d07ac385..a2657bf9 100644 --- a/rubyzip.gemspec +++ b/rubyzip.gemspec @@ -16,4 +16,8 @@ spec = Gem::Specification.new do |s| s.require_paths = ['lib'] s.license = 'BSD 2-Clause' s.required_ruby_version = '>= 1.9.2' + s.add_development_dependency 'rake', '~> 10.3' + s.add_development_dependency 'pry', '~> 0.10' + s.add_development_dependency 'minitest', '~> 5.2.0' + s.add_development_dependency 'coveralls', '~> 0.7' end