New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sqrt overflow panic for values > T::MAX / 2 #1

Open

spearman opened this issue Jun 8, 2020 · 0 comments · May be fixed by #6

spearman commented Jun 8, 2020

Here's an example, seems to be the case for various integer/bit combinations of i32 and i64s:

use cordic;
use fixed;

type Ftype = fixed::types::I16F16;
type Itype = i32;
fn main() {
  // ok
  let x = Ftype::from_bits (Itype::MAX/2);
  dbg!(x);
  dbg!(cordic::sqrt (x));
  // thread 'main' panicked at 'overflow'
  let x = Ftype::from_bits (Itype::MAX/2 + 1);
  dbg!(x);
  dbg!(cordic::sqrt (x));
}

Backtrace points to fixed mul on src/lib.rs:213

The text was updated successfully, but these errors were encountered:

Zentropivity linked a pull request

that will close this issue

Fix sqrt overflow panic on high bit values #6

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment