Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frames_remaining not available for each source #12

Open
sebastian-heinz opened this issue Apr 20, 2021 · 2 comments
Open

frames_remaining not available for each source #12

sebastian-heinz opened this issue Apr 20, 2021 · 2 comments

Comments

@sebastian-heinz
Copy link
Owner

currently access lists that should only be used inside read() call.
It can cause issues as the lists are not thread safe.
@sebastian-heinz
Copy link
Owner Author

sebastian-heinz commented Apr 21, 2021 •
edited
Loading

it is now thread safe to call get_remaining_frames() from mixer since 85b3e79#diff-e6d60fcda4e109c878df568c91fb8bea1bcda93b905c9aaba463bb8e9890c3deR23

however there is currently no solution on how to count remaining frames from audio_data accurately, as it can be reset or canceled mid way

@sebastian-heinz
Copy link
Owner Author

remaining frames is available in audio_data and audio_stream.
However audio_space does not provide the information, and mixer also does not, but it would be the larges number of available frames among its sources

@sebastian-heinz sebastian-heinz changed the title rework AudioMixer::frames_remaining frames_remaining not available for each source Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebastian-heinz