-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awards - missing picture element in page. #36
Comments
still issues with upload and missing image element |
hi @imbabamba. thanks for raising this with us. do you have user authentication set up on your backstage instance? the awards backend requires user authentication to run: backstage-plugins/plugins/awards-backend/README.md Lines 7 to 9 in 086782d
this looks like it may be an issue where a user token isn't set up and so the auth layer is sending an "Access Denied". if you do have auth set up on your production instance but not on your local instance, you can try adding something like we did to your local config to get a "dummy" auth system running: https://github.com/seatgeek/backstage-plugins/blob/main/packages/backend/src/plugins/auth.ts. |
@zhammer hi. First of all, awesome plugin! and thanks for replying! I will look into the backend 2 backend auth again. But what about the emtpy 'preview' element issue? Also would be great if "Aspect ration 3:1" text could be changed to like 150x50 px and warn about a more reasonable image size since most users wont understand which size is actually needed to get it to work. |
for the image preview issue, can you reload your page with network inspector on and check what the response on that image is? i'm not sure what's going on there. agreed that the aspect ratio instruction is a little confusing. there's also rules on image size (max and min) on the backend that aren't clearly expressed there. i can take a look on how this is expressed on other UIs. |
ah, this may just be some poor UI carried over from a change when this used to be autopopulated, it's not anymore. if you want to push up a change where that image element isn't rendered at all when there's no image uploaded yet, i'm happy to approve. backstage-plugins/plugins/awards/src/components/AwardEditComponent/AwardEditComponent.tsx Lines 225 to 227 in 086782d
|
I can wait til you have changed this. :) |
How do I fix this missing picture element?
The text was updated successfully, but these errors were encountered: