Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Linking a Adventure to Collection removes Visits #424

Closed
JesperDramsch opened this issue Jan 3, 2025 · 2 comments · Fixed by #423
Closed

[BUG] Linking a Adventure to Collection removes Visits #424

JesperDramsch opened this issue Jan 3, 2025 · 2 comments · Fixed by #423
Assignees
Labels
bug Something isn't working

Comments

@JesperDramsch
Copy link

Describe the bug
When you link an existing adventure to a collection, it removes the visits on this adventure.

To Reproduce
Steps to reproduce the behavior:

  1. Create an adventure with visits
  2. Link to Collection
  3. Wonder why visits are gone

Expected behavior
I expect a linked adventure to keep all visits.

(Maybe I misunderstand how collections work, but for example if I add the "Big Ben historical site" adventure I want to be able to visit it multiple times. Probably fits with #336 )

@JesperDramsch JesperDramsch added the bug Something isn't working label Jan 3, 2025
@seanmorley15
Copy link
Owner

Yes this is a bug, thanks for discovering it. I was just able to diagnose and fix it in the development branch. Now when adventures are linked and unlinked from collections, all of the logged visits will remain. Thanks for finding this, it will be released with the next PR to main 😃

@seanmorley15 seanmorley15 moved this to In review in AdventureLog Roadmap Jan 3, 2025
@seanmorley15 seanmorley15 self-assigned this Jan 3, 2025
@JesperDramsch
Copy link
Author

Amazing thanks @seanmorley15 !

@github-project-automation github-project-automation bot moved this from In review to Done in AdventureLog Roadmap Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants