Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading indicator never displays #1

Open
seanlowe opened this issue Apr 29, 2023 · 0 comments · May be fixed by #6
Open

Loading indicator never displays #1

seanlowe opened this issue Apr 29, 2023 · 0 comments · May be fixed by #6
Assignees
@seanlowe
Labels
bug Something isn't working

Comments

@seanlowe
Copy link
Owner

Accidentally left the initial isLoading state as false from when I changed it for quicker local testing.

Files affected:

  • rover/list.jsx
  • rover/detailView.jsx
@seanlowe seanlowe added the bug Something isn't working label Apr 29, 2023
@seanlowe seanlowe self-assigned this May 3, 2023
seanlowe added a commit that referenced this issue May 3, 2023
@seanlowe
#1 show loading text when loading
6500cab 
* flips the initial state for isLoading on both components
* adds a new loading layout component for DRY
* some styling tweaks
@seanlowe seanlowe linked a pull request May 3, 2023 that will close this issue
#1 show loading text when loading #6
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanlowe seanlowe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1 show loading text when loading seanlowe/rover-app
1 participant
@seanlowe