Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshing on Detail View page breaks app #3

Open
seanlowe opened this issue Apr 29, 2023 · 0 comments · May be fixed by #5
Open

Refreshing on Detail View page breaks app #3

seanlowe opened this issue Apr 29, 2023 · 0 comments · May be fixed by #5
Assignees
@seanlowe
Labels
bug Something isn't working

Comments

@seanlowe
Copy link
Owner

Due to the way I originally coded the detail view page, if the user refreshes while currently on the detail view page, the app breaks because the original query param isn't persisted.

Possible fix: early return or forced redirect to list view when there isn't a rover
@seanlowe seanlowe added the bug Something isn't working label Apr 29, 2023
@seanlowe seanlowe self-assigned this May 2, 2023
seanlowe added a commit that referenced this issue May 3, 2023
@seanlowe
#3 fix app crash when refreshing photos page
284620b 
Adds a context between the list page and photos page with shared data on what the rover is. If we are on the photos page and we don't know what the rover is, then we redirect back to the list page.
seanlowe added a commit that referenced this issue May 3, 2023
@seanlowe
#3 remove error silencing
c1a2f31
@seanlowe seanlowe linked a pull request May 3, 2023 that will close this issue
3 refreshing on detail view page breaks app #5
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanlowe seanlowe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3 refreshing on detail view page breaks app seanlowe/rover-app
1 participant
@seanlowe