Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code smells #4

Open
seanlowe opened this issue Apr 29, 2023 · 0 comments
Open

Clean up code smells #4

seanlowe opened this issue Apr 29, 2023 · 0 comments
Assignees
Labels
clean-up Refactors or general tidying up

Comments

@seanlowe
Copy link
Owner

Clean up bad code practices and/or remnants of more complex functionality that was refactored:

detailView.jsx:

  • double switch in currentApiUrl useEffect (left over from first iteration of pagination and forgot to clean up. Used double switch instead of multiple nested if statements.)
  • remove unnecessary fragment wrappers in renderPhotos. I think I added these in before I changed how I was returning JSX in that section and didn't remove the newly unneeded fragments.
  • change unnecessary div to fragment in default return

helpers.jsx

  • change Int to Number in JSDoc.... we're in JS

list.jsx

  • change unnecessary div to fragment in default return
@seanlowe seanlowe added the clean-up Refactors or general tidying up label Apr 29, 2023
@seanlowe seanlowe self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up Refactors or general tidying up
Projects
None yet
Development

No branches or pull requests

1 participant