Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: full refactoring for the whole project #102

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

refactor: full refactoring for the whole project #102

wants to merge 18 commits into from

Conversation

MaikoTan
Copy link
Member

@MaikoTan MaikoTan commented May 19, 2023 •
edited
Loading

Description

This is a full refactoring for the whole project. It can be summarized as the following:

  • Replace aiohttp to requests, also removed asyncio and all asynchronized code

    The async causes many problems with gradio and fastapi that we required to communicate with the Stable Horde side. Replacing it with the old school requests solved this.

  • Split the UI Page into Worker and User

    So it is able to manage your user resources in the WebUI now

  • Apply Interactive Outputs feature on result image receiving

    This might be a bit improvement for the performance.

Close #57
Close #83

Type of changes

  • Bugfix
  • Feature
  • Refactoring

Please check the following items before submitting your pull request

  • I've checked that this isn't a duplicate pull request.
  • I've tested my changes with the latest SD-Webui version.
  • I've format my code with black: black .
  • I've lint my code with flake8: flake8 .
  • I've read the Contribution Guidelines
  • I've read the Code of Conduct

@theUpsider
Copy link
Contributor

@MaikoTan Hows it going? Do you need help? Currently finding time again to do some work in spare time again ^^

@MaikoTan
Copy link
Member Author

MaikoTan commented Jul 5, 2023

@MaikoTan Hows it going? Do you need help? Currently finding time again to do some work in spare time again ^^

Yes! It would be great if you could help.

Currently this PR is working, but I want to add more things before merging it:

  1. Model (checkpoint) list, with download feature.
    I am not sure how to implement the download feature or even the list itself. I think the easy way is to write js script and fetch models from stable horde, then add an <a> tag point to the download link besides the model name as a download button.
  2. A full-featured user page, at least there should be names, kudos, generated images count, workers list (with maintenance mode switching).
    I didn't found a way to verify "which worker is this sd-webui instance", so maybe we should just listing all workers belongs to the current user.

@theUpsider
Copy link
Contributor

I might join you on this! Are you on discord btw?

@MaikoTan
Copy link
Member Author

MaikoTan commented Jul 7, 2023 •
edited
Loading

I might join you on this! Are you on discord btw?

Sure, my discord is Maiko#7778

@MaikoTan MaikoTan mentioned this pull request Jul 7, 2023
Merged
7 tasks
@gabriel20xx
Copy link
Contributor

What's the status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR Review
Status: Waiting for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Expose User Kudos int he extension UI. [Feature]: add maintenance mode switch
3 participants
@MaikoTan @theUpsider @gabriel20xx