Skip to content

Commit f7f4345

Browse files
authored
Fix DayZSynthesizer.create_parameters errors in Colab with numeric columns (#2706)
1 parent ab196b8 commit f7f4345

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

sdv/single_table/_dayz_utils.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ def detect_column_parameters(data, metadata, table_name):
4242
if sdtype == 'numerical':
4343
column_parameters[column_name] = {
4444
'num_decimal_digits': learn_rounding_digits(data[column_name]),
45-
'min_value': data[column_name].min().item(),
46-
'max_value': data[column_name].max().item(),
45+
'min_value': data[column_name].min(),
46+
'max_value': data[column_name].max(),
4747
}
4848
elif sdtype == 'datetime':
4949
datetime_format = column_metadata.get('datetime_format', None)
@@ -63,13 +63,13 @@ def detect_column_parameters(data, metadata, table_name):
6363
'start_timestamp': start_timestamp,
6464
'end_timestamp': end_timestamp,
6565
}
66-
elif sdtype in ['categorical', 'boolean']:
66+
elif sdtype == 'categorical':
6767
column_parameters[column_name] = {
6868
'category_values': data[column_name].dropna().unique().tolist()
6969
}
7070

71-
column_parameters[column_name]['missing_values_proportion'] = (
72-
data[column_name].isna().mean().item()
71+
column_parameters[column_name]['missing_values_proportion'] = float(
72+
data[column_name].isna().mean()
7373
)
7474

7575
return {'columns': column_parameters}

tests/integration/multi_table/test_dayz.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def test_create_parameters_end_to_end(self):
2424
'guest_email': {'missing_values_proportion': 0.0},
2525
'hotel_id': {'missing_values_proportion': 0.0},
2626
'has_rewards': {
27-
'category_values': [False, True],
2827
'missing_values_proportion': 0.0,
2928
},
3029
'room_type': {

tests/integration/single_table/test_dayz.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ def test_create_parameters_end_to_end(self):
2323
'columns': {
2424
'guest_email': {'missing_values_proportion': 0.0},
2525
'has_rewards': {
26-
'category_values': [False, True],
2726
'missing_values_proportion': 0.0,
2827
},
2928
'room_type': {

0 commit comments

Comments
 (0)