Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use substring instead of regex to get the extension (Performance) #19

Open
cburgdorf opened this issue Oct 18, 2013 · 5 comments
Open

Use substring instead of regex to get the extension (Performance) #19

cburgdorf opened this issue Oct 18, 2013 · 5 comments

Comments

@cburgdorf
Copy link

See:

http://jsperf.com/file-extension-regex-vs-substr
@sdepold
Copy link
Owner

sdepold commented Oct 29, 2013

good point :)

@sdepold
Copy link
Owner

sdepold commented Oct 29, 2013

wanna send me a PR?

@cburgdorf
Copy link
Author

I probably send a couple of PRs over the next weeks but it will take some time until I get back to that task. Probably mid/end November. Btw, I would love to discuss some things regarding scalability/performance with you. Also hosting related stuff. Should I open a ticket for discussion?

@sdepold
Copy link
Owner

sdepold commented Oct 29, 2013

either that or we could chat on skype (or something similiar)

@cburgdorf
Copy link
Author

A Skype chat would be great! I'm christoph.burgdorf on Skype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdepold @cburgdorf