control-connection: tolerate schema agreement connection loss#856
Draft
dkropachev wants to merge 2 commits intoscylladb:masterfrom
Draft
control-connection: tolerate schema agreement connection loss#856dkropachev wants to merge 2 commits intoscylladb:masterfrom
dkropachev wants to merge 2 commits intoscylladb:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ControlConnection.wait_for_schema_agreementfall back to a same-host session pool connection when the control connection is gone, closed, defunct, busy, or raises a connection error.Falsewhen no same-host fallback connection is available._connectioncan still map to the correct host pool.Risks
Tests
repo-ci fast: unit phases passed; latest detailed log showed660 passed, 77 skippedplus gevent reactor2 passedduring the cp310 wheel leg. Overall run timed out at 300s during the broader cp311 wheel leg, with no test failure reported.Integration