Skip to content

_create_adata in test_score_genes doesen't work properly #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Reovirus opened this issue Apr 11, 2025 · 1 comment · May be fixed by #3590
Open

_create_adata in test_score_genes doesen't work properly #3580

Reovirus opened this issue Apr 11, 2025 · 1 comment · May be fixed by #3590
Labels
Development Process 🚀
Milestone
1.11.2

Comments

@Reovirus
Copy link

What kind of feature would you like to request?

Additional function parameters / changed functionality / changed defaults?

Please describe your wishes

_create_random_gene_names have no checks to name unique, as a result we have gene name duplicates and errors like pandas.errors.InvalidIndexError: Reindexing only valid with uniquely valued Index objects when testing

  1. Fixed random seed is needed to test reproducibility
  2. Rewrite function

Maybe we should use set.add and check set length
@Reovirus Reovirus added the Triage 🩺 This issue needs to be triaged by a maintainer label Apr 11, 2025
@flying-sheep flying-sheep linked a pull request Apr 14, 2025 that will close this issue
Open
4 tasks
@flying-sheep flying-sheep added Development Process 🚀 and removed Triage 🩺 This issue needs to be triaged by a maintainer labels Apr 14, 2025
@flying-sheep
Copy link
Member

For sure! I came up with something in #3590. Check it out if you want!

@flying-sheep flying-sheep added this to the 1.11.2 milestone Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Development Process 🚀
Projects
None yet
Milestone
1.11.2
Development

Successfully merging a pull request may close this issue.

Centralize random utils scverse/scanpy
2 participants
@flying-sheep @Reovirus