Fix clippy warnings (#851)

* Run and build the complete workspace. Also update the toolchain such that get the newest clippy warnings

* `start` feature was removed

* Remove `test-no-std` from the default members instead of removing it manually from most builds

* Remove the `workspace` flag as it leads to inclusion of the `test-no-std` package

* Fix clippy issues

* Update pipeline commands for clippy

* Update test command for pipeline

* Add missing comma

* Fix clippy issues

* Add box import only when `std` feature is not active

* Ignore some clippy issues

* Add fixes for keystore

* Don't check examples and ignore some more warning

* Remove taplo for now

* Remove exclude for keystore

Author: Niederb

.github/workflows/ci.yml

@@ -46,7 +46,7 @@ jobs:
         check: [
                 # Test for no-std compatibility.
                 # `--locked` to enforce an up-to-date Cargo.lock
-                cargo build --release --workspace --locked --exclude test-no-std,
+                cargo build --release --locked,
 
                 # We need to compile `test-no-std` separately, otherwise we have std leaks from the build-deps.
                 #
@@ -58,14 +58,14 @@ jobs:
                 cargo build --release -p test-no-std --features primitives,
 
                 # Check build of stand-alone features.
-                cargo check --no-default-features -p substrate-api-client,
-                cargo check --no-default-features -p substrate-api-client --features sync-api,
-                cargo check --no-default-features -p substrate-api-client --features jsonrpsee-client,
-                cargo check --no-default-features -p substrate-api-client --features tungstenite-client,
-                cargo check --no-default-features -p substrate-api-client --features ws-client,
-                cargo check --no-default-features -p substrate-api-client --features staking-xt,
-                cargo check --no-default-features -p substrate-api-client --features contracts-xt,
-                cargo check --no-default-features -p substrate-api-client --features std,
+                cargo check --no-default-features,
+                cargo check --no-default-features --features sync-api,
+                cargo check --no-default-features --features jsonrpsee-client,
+                cargo check --no-default-features --features tungstenite-client,
+                cargo check --no-default-features --features ws-client,
+                cargo check --no-default-features --features staking-xt,
+                cargo check --no-default-features --features contracts-xt,
+                cargo check --no-default-features --features std,
 
                 # Test for 32 bit and wasm32-unknown-unknown compatibility
                 cargo build -p substrate-api-client --target wasm32-unknown-unknown --no-default-features --features sync-api,
@@ -81,12 +81,12 @@ jobs:
                 cargo test --release -p ac-testing-sync,
 
                 # Clippy
-                cargo clippy -p substrate-api-client -- -D warnings,
-                cargo clippy -p substrate-api-client --no-default-features -- -D warnings,
-                cargo clippy -p substrate-api-client --all-features --examples -- -D warnings,
+                cargo clippy --workspace --exclude test-no-std -- -D warnings,
+                cargo clippy --workspace --exclude test-no-std --no-default-features -- -D warnings,
+                cargo clippy --workspace --exclude test-no-std --all-features -- -D warnings,
 
                 # Run unit tests
-                cargo test --release --all-features --workspace --exclude test-no-std --exclude "ac-examples-*" --exclude "ac-testing-*",
+                cargo test --release --all-features --workspace --exclude "ac-examples-*" --exclude "ac-testing-*" --exclude "test-no-std",
 
                 # Fmt
                 cargo fmt --all -- --check
@@ -168,15 +168,16 @@ jobs:
             !target/release/examples/*.d
             !target/release/examples/*-*
 
-  taplo-fmt:
-    name: "Taplo fmt"
-    runs-on: ubuntu-latest
-    container: "tamasfe/taplo:latest"
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Run Taplo fmt
-        run: taplo fmt --check
+# Remove taplo until https://github.com/tamasfe/taplo/issues/793 is resolved.
+#   taplo-fmt:
+#     name: "Taplo fmt"
+#     runs-on: ubuntu-latest
+#     container: "tamasfe/taplo:latest"
+#     steps:
+#       - uses: actions/checkout@v4
+# 
+#       - name: Run Taplo fmt
+#         run: taplo fmt --check
 
   license-check:
     name: "License check"

Cargo.toml

@@ -14,6 +14,20 @@ members = [
     "testing/sync",
 ]
 
+# Exclude the "test-no-std" package as it needs special treatment for compilation
+default-members = [
+    "api-client",
+    "keystore",
+    "compose-macros",
+    "primitives",
+    "examples/async",
+    "examples/sync",
+    "examples/wasm",
+    "node-api",
+    "testing/async",
+    "testing/sync",
+]
+
 [workspace.dependencies]
 # crates.io no_std
 async-trait = "0.1"

api-client/src/api/api_client.rs

@@ -20,7 +20,7 @@ use crate::{
 use ac_compose_macros::rpc_params;
 use ac_node_api::metadata::Metadata;
 use ac_primitives::{Config, ExtrinsicParams, SignExtrinsic};
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 use alloc::sync::Arc;
 use codec::Decode;
@@ -149,23 +149,23 @@ where
 			runtime_version_future,
 		)
 		.await?;
-		info!("Got genesis hash: {:?}", genesis_hash);
-		debug!("Metadata: {:?}", metadata);
-		info!("Runtime Version: {:?}", runtime_version);
+		info!("Got genesis hash: {genesis_hash:?}");
+		debug!("Metadata: {metadata:?}");
+		info!("Runtime Version: {runtime_version:?}");
 		Ok(Self::new_offline(genesis_hash, metadata, runtime_version, client))
 	}
 
 	/// Create a new Api client with call to the node to retrieve metadata.
 	#[maybe_async::sync_impl]
 	pub fn new(client: Client) -> Result<Self> {
 		let genesis_hash = Self::get_genesis_hash(&client)?;
-		info!("Got genesis hash: {:?}", genesis_hash);
+		info!("Got genesis hash: {genesis_hash:?}");
 
 		let metadata = Self::get_metadata(&client)?;
-		debug!("Metadata: {:?}", metadata);
+		debug!("Metadata: {metadata:?}");
 
 		let runtime_version = Self::get_runtime_version(&client)?;
-		info!("Runtime Version: {:?}", runtime_version);
+		info!("Runtime Version: {runtime_version:?}");
 
 		Ok(Self::new_offline(genesis_hash, metadata, runtime_version, client))
 	}
@@ -189,8 +189,8 @@ where
 		let metadata = Self::get_metadata(&self.client)?;
 		let runtime_version = Self::get_runtime_version(&self.client)?;
 
-		debug!("Metadata: {:?}", metadata);
-		info!("Runtime Version: {:?}", runtime_version);
+		debug!("Metadata: {metadata:?}");
+		info!("Runtime Version: {runtime_version:?}");
 
 		self.metadata = metadata;
 		self.runtime_version = runtime_version;

api-client/src/api/mod.rs

@@ -340,7 +340,7 @@ mod tests {
 	fn encode_decode_extrinsic_report() {
 		let hash = H256::random();
 		let block_hash = H256::random();
-		let status = TransactionStatus::InBlock(block_hash.clone());
+		let status = TransactionStatus::InBlock(block_hash);
 		// RawEventDetails Encoding / Decoding is already tested separately, so we don't need to retest here.
 		let report = ExtrinsicReport::new(hash, Some(block_hash), status, None);
 

api-client/src/api/rpc_api/author.rs

@@ -20,7 +20,7 @@ use crate::{
 };
 use ac_compose_macros::rpc_params;
 use ac_primitives::{config::Config, UncheckedExtrinsic};
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 use codec::{Decode, Encode};
 use log::*;
@@ -76,7 +76,7 @@ where
 
 	async fn submit_opaque_extrinsic(&self, encoded_extrinsic: &Bytes) -> Result<Self::Hash> {
 		let hex_encoded_xt = rpc_params![encoded_extrinsic];
-		debug!("sending extrinsic: {:?}", hex_encoded_xt);
+		debug!("sending extrinsic: {hex_encoded_xt:?}");
 		let xt_hash = self.client().request("author_submitExtrinsic", hex_encoded_xt).await?;
 		Ok(xt_hash)
 	}
@@ -283,7 +283,7 @@ where
 		}
 		self.populate_events(&mut report).await?;
 		report.check_events_for_dispatch_error(self.metadata())?;
-		return Ok(report);
+		Ok(report)
 	}
 
 	async fn populate_events(&self, report: &mut ExtrinsicReport<Self::Hash>) -> Result<()> {

api-client/src/api/rpc_api/chain.rs

@@ -18,7 +18,7 @@ use crate::{
 };
 use ac_compose_macros::rpc_params;
 use ac_primitives::config::Config;
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 use alloc::vec::Vec;
 use log::*;

api-client/src/api/rpc_api/events.rs

@@ -19,7 +19,7 @@ use crate::{
 use ac_compose_macros::rpc_params;
 use ac_node_api::{metadata::Metadata, EventDetails, EventRecord, Events, Phase};
 use ac_primitives::config::Config;
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 use alloc::{vec, vec::Vec};
 use codec::{Decode, Encode};
@@ -197,7 +197,7 @@ where
 			.iter()
 			.position(|xt| {
 				let xt_hash = T::Hasher::hash_of(&xt);
-				trace!("Looking for: {:?}, got xt_hash {:?}", extrinsic_hash, xt_hash);
+				trace!("Looking for: {extrinsic_hash:?}, got xt_hash {xt_hash:?}");
 				extrinsic_hash == xt_hash
 			})
 			.ok_or(Error::ExtrinsicNotFound)?;

api-client/src/api/rpc_api/frame_system.rs

@@ -19,7 +19,7 @@ use crate::{
 };
 use ac_compose_macros::rpc_params;
 use ac_primitives::{config::Config, AccountInfo};
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 use alloc::{string::String, vec::Vec};
 use log::*;

api-client/src/api/rpc_api/pallet_balances.rs

@@ -15,7 +15,7 @@ use crate::{
 	rpc::Request,
 };
 use ac_primitives::config::Config;
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 
 /// Interface to common calls of the substrate balances pallet.

api-client/src/api/rpc_api/pallet_transaction_payment.rs

@@ -16,7 +16,7 @@ use crate::{
 };
 use ac_compose_macros::rpc_params;
 use ac_primitives::{config::Config, FeeDetails, InclusionFee, NumberOrHex, RuntimeDispatchInfo};
-#[cfg(not(feature = "sync-api"))]
+#[cfg(all(not(feature = "sync-api"), not(feature = "std")))]
 use alloc::boxed::Box;
 use core::str::FromStr;
 use sp_core::Bytes;