Prepare for v2

* Support JWT gem v3
* Drop support for rubies < 3.4
* Update development dependencies
* Enforce MFA on gem push
* Rely less on auto-inject for private APIs
* Use dry-configurable instead of auto-injecting config

Author: scryptmouse

.github/workflows/main.yml

@@ -15,34 +15,34 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     env:
+      RUBY_VERSION: ruby-4.0.1
+      RUBOCOP_CACHE_ROOT: tmp/rubocop
       APPRAISAL_NAME: rack_3
       BUNDLE_GEMFILE: ./gemfiles/rack_3.gemfile
     steps:
       - uses: actions/checkout@v2
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.0.0
-      - uses: actions/cache@v4
+          ruby-version: ${{ env.RUBY_VERSION }}
+          bundler-cache: true
+      - uses: actions/cache@v5
+        env:
+          DEPENDENCIES_HASH: ${{ hashFiles('.rubocop.yml', '.rubocop_todo.yml', format('{0}.lock', env.BUNDLE_GEMFILE)) }}
         with:
-          path: vendor/bundle
-          key: bundle-use-ruby-ubuntu-latest-3.0.0-rack_3-${{ hashFiles(format('{0}.lock', env.BUNDLE_GEMFILE)) }}
+          path: ${{ env.RUBOCOP_CACHE_ROOT }}
+          key: rubocop-${{ runner.os }}-${{ env.RUBY_VERSION }}-${{ env.DEPENDENCIES_HASH }}-${{ github.ref_name == github.event.repository.default_branch && github.run_id || 'default' }}
           restore-keys: |
-            bundle-use-ruby-ubuntu-latest-3.0.0-rack_3
-      - name: bundle install
-        run: |
-          bundle config deployment true
-          bundle config path vendor/bundle
-          bundle install --jobs 4
+            rubocop-${{ runner.os }}-${{ env.RUBY_VERSION }}-${{ env.DEPENDENCIES_HASH }}-
       - name: "Run rubocop"
         run: |
-          bin/rubocop
+          bin/rubocop -f github
   rspec:
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        appraisal_name: [rack_2, rack_3, rails_6_0, rails_6_1]
-        ruby: [3.0.0]
+        appraisal_name: [jwt_2, jwt_3, rack_2, rack_3, rails_7_1, rails_7_2, rails_8_0, rails_8_1]
+        ruby: [3.4.7, 4.0.1]
     env:
       APPRAISAL_NAME: ${{ matrix.appraisal_name }}
       BUNDLE_GEMFILE: ${{ format('./gemfiles/{0}.gemfile', matrix.appraisal_name) }}
@@ -51,17 +51,7 @@ jobs:
       - uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-      - uses: actions/cache@v4
-        with:
-          path: vendor/bundle
-          key: bundle-use-ruby-ubuntu-latest-${{ matrix.ruby }}-${{ env.APPRAISAL_NAME }}-${{ hashFiles(format('{0}.lock', env.BUNDLE_GEMFILE)) }}
-          restore-keys: |
-            bundle-use-ruby-ubuntu-latest-${{ matrix.ruby }}-${{ env.APPRAISAL_NAME }}
-      - name: bundle install
-        run: |
-          bundle config deployment true
-          bundle config path vendor/bundle
-          bundle install --jobs 4
+          bundler-cache: true
       - name: "Run RSpec"
         run: |
           bin/rspec

.gitignore

@@ -6,3 +6,5 @@
 /spec/examples.txt
 /.yardoc
 /_yardoc/
+spec/dummy/log
+spec/dummy/tmp

.rubocop.yml

@@ -1,20 +1,31 @@
-require:
+plugins:
+  - rubocop-factory_bot
   - rubocop-rake
   - rubocop-rspec
 
 AllCops:
+  NewCops: enable
   Exclude:
     - Appraisals
     - "bin/*"
     - "gemfiles/**/*"
-  TargetRubyVersion: 3.0
+    - "vendor/**/*"
+  TargetRubyVersion: 3.4
 
 Bundler/OrderedGems:
   Enabled: false
 
-Gemspec/DateAssignment:
+# Explicit is better.
+FactoryBot/SyntaxMethods:
+  Enabled: false
+
+Gemspec/DeprecatedAttributeAssignment:
   Enabled: true
 
+# We use appraisals.
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
 Layout/ArgumentAlignment:
   Enabled: false
 
@@ -98,7 +109,7 @@ Lint/UnusedMethodArgument:
   Enabled: false
 
 Metrics/AbcSize:
-  Max: 25
+  Max: 30
 
 # This doesn't work with anything that uses a DSL
 Metrics/BlockLength:
@@ -113,7 +124,7 @@ Metrics/MethodLength:
 Naming/MethodName:
   Enabled: false
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   ForbiddenPrefixes:
     - is_
 
@@ -126,6 +137,9 @@ RSpec/DescribeClass:
 RSpec/DescribedClass:
   Enabled: false
 
+RSpec/ExampleWording:
+  Enabled: false
+
 RSpec/LeadingSubject:
   Enabled: false
 

Appraisals

@@ -1,5 +1,13 @@
 # frozen_string_literal: true
 
+appraise "jwt_2" do
+  gem "jwt", ">= 2.2.0", "< 3"
+end
+
+appraise "jwt_3" do
+  gem "jwt", ">= 3", "< 4"
+end
+
 appraise "rack_2" do
   gem "rack", ">= 2.2", "< 3"
 end
@@ -8,14 +16,26 @@ appraise "rack_3" do
   gem "rack", ">= 3", "< 4"
 end
 
-appraise "rails_6_0" do
-  gem "rails", ">= 6", "< 6.1.0"
+appraise "rails_7_1" do
+  gem "rails", ">= 7.1.0", "< 8.0.0"
+
+  gem "rspec-rails", "5.0.1"
+end
+
+appraise "rails_7_2" do
+  gem "rails", ">= 7.2.0", "< 8.0.0"
+
+  gem "rspec-rails", "5.0.1"
+end
+
+appraise "rails_8_0" do
+  gem "rails", ">= 8.0.0", "< 9.0.0"
 
   gem "rspec-rails", "5.0.1"
 end
 
-appraise "rails_6_1" do
-  gem "rails", ">= 6.1.0", "< 6.2.0"
+appraise "rails_8_1" do
+  gem "rails", ">= 8.0.0", "< 9.0.0"
 
   gem "rspec-rails", "5.0.1"
 end

bin/appraisal

@@ -8,22 +8,9 @@
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-bundle_binstub = File.expand_path("../bundle", __FILE__)
-
-if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
-    load(bundle_binstub)
-  else
-    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
-Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
-  end
-end
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
 
 require "rubygems"
 require "bundler/setup"
 
-load Gem.bin_path("appraisal", "appraisal")
+load Gem.bin_path("appraisal2", "appraisal")

gemfiles/jwt_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal2
+
+source "https://rubygems.org"
+
+gem "jwt", ">= 2.2.0", "< 3"
+
+gemspec :path => "../"