Merge pull request #98 from darwinzer0/master

azaidelson · web-flow · commit cc089ba27cc4 · 2025-02-18T10:38:55.000+02:00
fix out of bounds bug
diff --git a/packages/storage/src/append_store.rs b/packages/storage/src/append_store.rs
@@ -160,7 +160,7 @@ impl<'a, T: Serialize + DeserializeOwned, Ser: Serde> AppendStore<'a, T, Ser> {
     /// gets the element at pos if within bounds
     pub fn get_at(&self, storage: &dyn Storage, pos: u32) -> StdResult<T> {
         let len = self.get_len(storage)?;
-        if pos > len {
+        if pos >= len {
             return Err(StdError::generic_err("append_store access out of bounds"));
         }
         self.get_at_unchecked(storage, pos)

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ impl<'a, T: Serialize + DeserializeOwned, Ser: Serde> AppendStore<'a, T, Ser> {`
`160`	`160`	`/// gets the element at pos if within bounds`
`161`	`161`	`pub fn get_at(&self, storage: &dyn Storage, pos: u32) -> StdResult<T> {`
`162`	`162`	`let len = self.get_len(storage)?;`
`163`		`- if pos > len {`
	`163`	`+ if pos >= len {`
`164`	`164`	`return Err(StdError::generic_err("append_store access out of bounds"));`
`165`	`165`	`}`
`166`	`166`	`self.get_at_unchecked(storage, pos)`