From 598a73c34d30028ac45903464b60afa704863ab8 Mon Sep 17 00:00:00 2001 From: FilippoPetroli Date: Thu, 9 Mar 2023 15:33:06 -0300 Subject: [PATCH] Fix issue 99 --- scrapy_poet/api.py | 7 +++---- tests/test_downloader.py | 8 ++++++++ 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/scrapy_poet/api.py b/scrapy_poet/api.py index 5a5b95db..942edced 100644 --- a/scrapy_poet/api.py +++ b/scrapy_poet/api.py @@ -1,7 +1,7 @@ from inspect import iscoroutinefunction -from typing import Callable, Optional, Type +from typing import Callable, Type -from scrapy.http import Request, Response +from scrapy.http import Response from web_poet.pages import ItemPage _CALLBACK_FOR_MARKER = "__scrapy_poet_callback" @@ -27,8 +27,7 @@ def parse(self, response: DummyResponse): :class:`~.DummyResponse` to your parser instead. """ - def __init__(self, url: str, request=Optional[Request]): - super().__init__(url=url, request=request) + pass def callback_for(page_or_item_cls: Type) -> Callable: diff --git a/tests/test_downloader.py b/tests/test_downloader.py index 86641929..d9351410 100644 --- a/tests/test_downloader.py +++ b/tests/test_downloader.py @@ -501,6 +501,14 @@ def parse(self, response: DummyResponse): assert not isinstance(collected["response"], DummyResponse) +def test_dummy_response_multiple_args() -> None: + dummy = DummyResponse(url="https://google.com", request=None, status=300) + assert dummy.status == 300 + + dummy = DummyResponse("https://google.com", 400) + assert dummy.status == 400 + + @pytest.mark.skipif( is_min_scrapy_version("2.8.0"), reason="tests Scrapy < 2.8 before NO_CALLBACK was introduced",