Skip to content

Commit b2f7bb4

Browse files
authored
Merge pull request #148 from scrapinghub/msgpack-improve-deps
Improve msgpack related deps
2 parents 1788eef + 38cc26b commit b2f7bb4

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
-r requirements-base.txt
2-
msgpack>=0.6.1
2+
msgpack>=1.0.0

setup.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
version = f.read().decode('ascii').strip()
1212

1313
is_pypy = '__pypy__' in sys.builtin_module_names
14-
mpack_required = 'msgpack-pypy>=0.0.2' if is_pypy else 'msgpack>=1.0.0'
14+
mpack_required = ['msgpack>=1.0.0']
15+
if is_pypy:
16+
mpack_required.append('msgpack-pypy>=0.0.2')
1517

1618
setup(
1719
name='scrapinghub',
@@ -25,7 +27,7 @@
2527
packages=['scrapinghub', 'scrapinghub.client', 'scrapinghub.hubstorage'],
2628
package_data={'scrapinghub': ['VERSION']},
2729
install_requires=['requests>=1.0', 'retrying>=1.3.3', 'six>=1.10.0'],
28-
extras_require={'msgpack': [mpack_required]},
30+
extras_require={'msgpack': mpack_required},
2931
classifiers=[
3032
'Development Status :: 5 - Production/Stable',
3133
'License :: OSI Approved :: BSD License',

0 commit comments

Comments
 (0)