Skip to content

Commit a057f1e

Browse files
committed
using constants instead of hardcoded values
1 parent 5064062 commit a057f1e

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

tests/conftest.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,20 @@
1414
DEFAULT_PROJECT_ID = "2222222"
1515
DEFAULT_ENDPOINT = 'http://storage.vm.scrapinghub.com'
1616
DEFAULT_DASH_ENDPOINT = 'http://33.33.33.51:8080/api/'
17+
DEFAULT_ADMIN_AUTH = 'f' * 32
18+
DEFAULT_USER_AUTH = 'e' * 32
1719

1820

1921
TEST_PROJECT_ID = os.getenv('HS_PROJECT_ID', DEFAULT_PROJECT_ID)
2022
TEST_SPIDER_NAME = 'hs-test-spider'
2123
TEST_FRONTIER_SLOT = 'site.com'
2224
TEST_BOTGROUP = 'python-hubstorage-test'
2325
TEST_COLLECTION_NAME = "test_collection_123"
24-
TEST_AUTH = os.getenv('HS_AUTH', 'f' * 32)
26+
TEST_AUTH = os.getenv('HS_AUTH', DEFAULT_ADMIN_AUTH)
2527
TEST_ENDPOINT = os.getenv('HS_ENDPOINT', DEFAULT_ENDPOINT)
2628
TEST_COLLECTION_NAME = "test_collection_123"
27-
TEST_ADMIN_AUTH = os.getenv('AUTH', 'f' * 32)
28-
TEST_USER_AUTH = os.getenv('USER_AUTH', 'e' * 32)
29+
TEST_ADMIN_AUTH = os.getenv('AUTH', DEFAULT_ADMIN_AUTH)
30+
TEST_USER_AUTH = os.getenv('USER_AUTH', DEFAULT_USER_AUTH)
2931
TEST_DASH_ENDPOINT = os.getenv('DASH_ENDPOINT', DEFAULT_DASH_ENDPOINT)
3032

3133

@@ -76,7 +78,7 @@ def normalize_cassette(cassette_dict):
7678
interaction['request']['headers']['Authorization'] = (
7779
'Basic {}'.format(
7880
base64.b64encode(
79-
'{}:'.format('f' * 32).encode('utf-8')
81+
'{}:'.format(DEFAULT_ADMIN_AUTH).encode('utf-8')
8082
).decode('utf-8')
8183
)
8284
)

0 commit comments

Comments
 (0)