Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails for http://www.imdb.com/title/tt0117500/ #1

Closed
davidrecordon opened this issue Apr 30, 2010 · 4 comments
Closed

Fails for http://www.imdb.com/title/tt0117500/ #1

davidrecordon opened this issue Apr 30, 2010 · 4 comments

Comments

@davidrecordon
Copy link

__values seems to be empty in line:
if (empty($page->_values)) { return false; }

@scottmac
Copy link
Owner

IMDB is using
<meta name="og:title"
The spec says
<meta property="og:title"

So is IMDB broken or not?

@scottmac
Copy link
Owner

They're also missing og:image and og:type which are required.

@davidrecordon
Copy link
Author

Yeah, they're broken. Ignore my use case.

@scottmac
Copy link
Owner

It's on the main open graph protocol site, maybe we should use Rotten Tomato as an example :)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants