null filter

Author: hkethi002

api/download.py

@@ -20,7 +20,11 @@
 def _filter_check(property_filter, property_values):
     minus = set(property_filter.get('-', []))
     plus = set(property_filter.get('+', []))
-    if not minus.isdisjoint(property_values):
+    if "null" in plus and not property_values:
+        return True
+    if "null" in minus and property_values:
+        return False
+    elif not minus.isdisjoint(property_values):
         return False
     if plus and plus.isdisjoint(property_values):
         return False

test/integration_tests/python/test_download.py

@@ -388,6 +388,8 @@ def test_filters(data_builder, file_form, as_admin):
     assert r.json()['file_cnt'] == 2
 
     # Filter by type
+    as_admin.post('/acquisitions/' + acquisition + '/files', files=file_form(
+        "test", meta={'name': "test", 'tags': ['red', 'blue']}))
     r = as_admin.post('/download', json={
         'optional': False,
         'filters': [
@@ -399,6 +401,17 @@ def test_filters(data_builder, file_form, as_admin):
     })
     assert r.ok
     assert r.json()['file_cnt'] == 1
+    r = as_admin.post('/download', json={
+        'optional': False,
+        'filters': [
+            {'types': {'+':['null']}}
+        ],
+        'nodes': [
+            {'level': 'session', '_id': session},
+        ]
+    })
+    assert r.ok
+    assert r.json()['file_cnt'] == 1
 
 def test_summary(data_builder, as_admin, file_form):
     project = data_builder.create_project(label='project1')