Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1302 +/- ##
==========================================
+ Coverage 72.51% 72.55% +0.04%
==========================================
Files 295 297 +2
Lines 25442 25651 +209
Branches 3565 3586 +21
==========================================
+ Hits 18449 18611 +162
- Misses 5488 5523 +35
- Partials 1505 1517 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mdesco
approved these changes
Feb 4, 2026
Contributor
mdesco
left a comment
There was a problem hiding this comment.
This looks great. I tested and reproduced the outputs. It would be nice to have a formal technical review from @karanphil or @CHrlS98 that have played with local fixels in the past PR.
| Compute the angular error (AE) for each segment of the streamlines. | ||
|
|
||
| For each segment of each streamline, the direction is compared with the | ||
| underlying peak (for single peak files like DTI) or with the closest peak |
Contributor
There was a problem hiding this comment.
si possible, ajouter le terme eigen_vector pour le peak ici.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick description
New script to compute the local angular error at each point of the streamline, compared to underlying peaks. For each point, the following segment direction is compared with the peaks in this voxel (nearest neighbor). If peaks come from DTI; simply compared to the vector e1. If peaks come from fODF, compared to the most aligned peak. The output is an angle in degree, saved in DPP. Value at the last coordinate of streamlines is always 0. Value if the voxel has no peak is also 0.
Optionally, the AE can also be saved as color, or projected to a map (mean of segments in that voxel).
Then, I also wanted a script to extract the worst N streamlines based on that value, so here it is at the same time.
I will add official tests soon, but this can already be tested.
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
Using on ISMRM here
Results:
The tractogram:

With "Toggle 2D fiber mappers"

The projected map:

Extracted worst 500 streamlines:

Checklist