diff --git a/Projects/BeeID/datamodulemaker.py b/Projects/BeeID/datamodulemaker.py index 571a5bd..7559e9e 100644 --- a/Projects/BeeID/datamodulemaker.py +++ b/Projects/BeeID/datamodulemaker.py @@ -57,7 +57,26 @@ def extract_all_files(sequence_names): filename += '.gz' get_data(filename, urlname) with tarfile.open(filename, "r:gz") as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) os.remove(filename)