CancellationToken support?

[bryanboettcher]

There are a lot of methods that are 'async' without CancellationToken parameters (like, all of them).

Is it possible to add CancellationTokens to these methods? Any considerations in doing so?

[makingbloke]

A second vote for that here. CancellationToken support is pretty much standard in MS methods in my experience. The only proviso is the parameter is usually the last parameter and optional (default value is default). Cheers

…

On Thu, 28 Oct 2021 at 16:06, Bryan Boettcher ***@***.***> wrote: There are a lot of methods that are 'async' without CancellationToken parameters (like, all of them). Is it possible to add CancellationTokens to these methods? Any considerations in doing so? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#649>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPMCPLE7O6PS23J6XEY2ILUJFRG3ANCNFSM5G5EDAOA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[LarsVonQualen]

Hey guys, I'm working on it over here: https://github.com/LarsVonQualen/NPoco hopefully it'll get merged 😄

[LarsVonQualen]

Corresponding PR: #662

[bradbamford]

How has this not gained more traction ?

[schotime]

Long time coming, but will be out in the next couple of weeks in v6. Thanks for the work @LarsVonQualen, as I've used lots of the code especially the tests.

#695