Filter Feature is only implemented for XPHeaderRenderer

[schoetbi]

The following header Renderes have no implementation:

• FlatHeaderRenderer
• GradientHeaderRenderer

Would it be possible to move implementation to HeaderRenderer Baseclass?

[adarmus]

Hi - I'm not sure. You are right, that the other renderers need some
implementation that shows the button arrow, but I don't think the button
from XPHeaderRenderer matches the style of the other renderers (i.e. the
button drawn by ThemeManager.DrawComboBoxButton). These renderers could do
with an implementation of the button that matches their style better.
If it did move to HeaderRenderer you would also need to move the
implementation of HitTest.

Adam

On 12 July 2016 at 14:50, schoetbi notifications@github.com wrote:

The following header Renderes have not implementation:

• FlatHeaderRenderer
• GradientHeaderRenderer

Would it be possible to move implementation to HeaderRenderer Baseclass?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#18, or mute the thread
https://github.com/notifications/unsubscribe/AHmpFpW5ifYN7n3I1EjlWKtYlkN_mkFbks5qU5uLgaJpZM4JKaiQ
.

[schoetbi]

I just started an branch for this. The appropriate styling can be done
later. As soon as I am finished I will tell you.

2016-07-12 16:06 GMT+02:00 adarmus notifications@github.com:

Hi - I'm not sure. You are right, that the other renderers need some
implementation that shows the button arrow, but I don't think the button
from XPHeaderRenderer matches the style of the other renderers (i.e. the
button drawn by ThemeManager.DrawComboBoxButton). These renderers could do
with an implementation of the button that matches their style better.
If it did move to HeaderRenderer you would also need to move the
implementation of HitTest.

Adam

On 12 July 2016 at 14:50, schoetbi notifications@github.com wrote:

The following header Renderes have not implementation:

• FlatHeaderRenderer
• GradientHeaderRenderer

Would it be possible to move implementation to HeaderRenderer Baseclass?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#18, or mute the thread
<
https://github.com/notifications/unsubscribe/AHmpFpW5ifYN7n3I1EjlWKtYlkN_mkFbks5qU5uLgaJpZM4JKaiQ

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#18 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAupDR1Zqlqmy90B1o_7mJ9-VwjlwrEjks5qU59qgaJpZM4JKaiQ
.