shadow mapping stub

Author: schell

crates/renderling/src/light/cpu.rs

@@ -66,7 +66,7 @@ mod test {
     #[test]
     fn shadow_mapping_sanity() {
         let ctx = crate::Context::headless(1024, 800);
-        let mut stage = ctx.new_stage().with_lighting(false);
+        let mut stage = ctx.new_stage();
         let camera = stage.new_value(Camera::default());
         let doc = stage
             .load_gltf_document_from_path(

crates/renderling/src/stage/gltf_support.rs

@@ -1004,7 +1004,15 @@ impl GltfDocument {
                         let light = stage.new_value(DirectionalLight {
                             direction: Vec3::NEG_Z,
                             color,
-                            intensity,
+                            // TODO: Set a unit for lighting.
+                            // We don't yet use a unit for our lighting, and we should.
+                            // NOTE:
+                            // glTF spec [1] says directional light is in lux, whereas spot and point are
+                            // in candelas. I haven't really set a unit, it's implicit in the shader, but it seems we
+                            // can roughly get candelas from lux by dividing by 683 [2].
+                            // 1. https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_lights_punctual/README.md
+                            // 2. https://depts.washington.edu/mictech/optics/me557/Radiometry.pdf
+                            intensity: intensity / 683.0,
                         });
 
                         (light.id().into(), LightDetails::Directional(light))

gltf/shadow_mapping_sanity.gltf

@@ -18,7 +18,7 @@
 						1,
 						1
 					],
-					"intensity":683000,
+					"intensity":6830,
 					"type":"directional",
 					"name":"Light"
 				}