Skip to content

Commit d77fb0f

Browse files
committed
chore: Clean up code
1 parent 5506d2e commit d77fb0f

File tree

6 files changed

+13
-75
lines changed

6 files changed

+13
-75
lines changed

src/main/java/com/scanoss/filters/AntFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
*
4040
*/
4141
public class AntFilter {
42-
List<String> patterns;
42+
private final List<String> patterns;
4343

4444
/**
4545
* Constructs an AntFilter with the specified list of patterns.

src/main/java/com/scanoss/filters/BaseFilter.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,16 @@
2626
import java.nio.file.Path;
2727
import java.util.function.Predicate;
2828

29-
@Slf4j
29+
3030
/**
3131
* An abstract base class that provides core filtering functionality for the SCANOSS filtering system.
3232
*/
33+
@Slf4j
3334
public abstract class BaseFilter {
3435
protected final FilterConfig config;
35-
protected GitIgnoreFilter gitIgnoreFilter;
36-
protected AntFilter antFilter;
37-
protected Predicate<Path> baseSkipFilter;
36+
protected final GitIgnoreFilter gitIgnoreFilter;
37+
protected final AntFilter antFilter;
38+
protected final Predicate<Path> baseSkipFilter;
3839

3940
/**
4041
* Constructs a BaseFilter with the specified configuration.

src/main/java/com/scanoss/filters/FilterConfig.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,20 @@
3535
public class FilterConfig {
3636

3737
@Builder.Default
38-
private List<String> gitIgnorePatterns = new ArrayList<>();
38+
private final List<String> gitIgnorePatterns = new ArrayList<>();
3939

4040
@Builder.Default
41-
private List<String> antPatterns = new ArrayList<>();
41+
private final List<String> antPatterns = new ArrayList<>();
4242

4343
@Builder.Default
44-
private Boolean hiddenFilesFolders = false;
44+
private final Boolean hiddenFilesFolders = false;
4545

4646
@Builder.Default
47-
private Boolean allFilesFolders = false;
47+
private final Boolean allFilesFolders = false;
4848

4949
@Builder.Default
50-
private Boolean allFolders = false;
50+
private final Boolean allFolders = false;
5151

5252
@Builder.Default
53-
private Boolean allExtensions = false;
53+
private final Boolean allExtensions = false;
5454
}

src/test/java/com/scanoss/TestAntPathMatcher.java

Lines changed: 0 additions & 62 deletions
This file was deleted.

src/test/java/com/scanoss/TestScanner.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131

3232
import java.io.FileWriter;
3333
import java.io.IOException;
34-
import java.sql.Array;
3534
import java.util.ArrayList;
3635
import java.util.Arrays;
3736
import java.util.List;

src/test/java/com/scanoss/TestSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void testSettingsFromExistingFile() {
8787
}
8888

8989
@Test
90-
public void testSettingsFromNonExistentFile() throws IOException {
90+
public void testSettingsFromNonExistentFile() {
9191
String methodName = new Object() {
9292
}.getClass().getEnclosingMethod().getName();
9393
log.info("<-- Starting {}", methodName);

0 commit comments

Comments
 (0)