Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex queries with OR/AND etc operand within the HTTP Server + other API Improvements #420

Closed
8times4 opened this issue Nov 29, 2024 · 2 comments

Comments

@8times4
Copy link

8times4 commented Nov 29, 2024

Is your feature request related to a problem? Please describe.

Currently the API server only allows handling of string queries without any OR/AND operand.
API server also has no option to define an API key, or port to be used. (API key would allow "some" protection towards the vault, although not even sure if that's useful)

Describe the solution you'd like

An optional flag for complex query parsing or straight up parsing it with the same method that happens within Obsidian UI.
An option to set both an API key and IP.

Describe alternatives you've considered

Simple queries will not let me use the API with OR/AND etc, so not really an option.
API Key and IP are not really necessary but I believe it'd offer some advantage with not a lot of work.

Additional context

This is how I've implemented the API stuff in my demo code:
image

Thank you!

@scambier
Copy link
Owner

Omnisearch itself does not support operands, by design. Advanced queries are better handled by the core search feature of Obsidian.

For the API HTTP server itself, you can set the port in the settings, and the IP is configurable directly in the settings file #396 (comment)

For the same reason that the IP setting is hidden and prefixed with DANGER_, I'm also quite lukewarm to the idea of an API key. It sets an expectation of security, and I don't want to have that responsibility 🤷‍♂️

@8times4
Copy link
Author

8times4 commented Nov 30, 2024

Omnisearch itself does not support operands, by design. Advanced queries are better handled by the core search feature of Obsidian.

For the API HTTP server itself, you can set the port in the settings, and the IP is configurable directly in the settings file #396 (comment)

For the same reason that the IP setting is hidden and prefixed with DANGER_, I'm also quite lukewarm to the idea of an API key. It sets an expectation of security, and I don't want to have that responsibility 🤷‍♂️

Ugh, my apologies, this was beyond skill issue tbh.. I should've versed myself much better with Obsidian and your docs before asking stupid questions.

Thanks for the reply, have a nice one!

@8times4 8times4 closed this as completed Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants