Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Extensible searchEngine(s) #416

Closed
maybe-hello-world opened this issue Nov 5, 2024 · 3 comments
Closed

[Feature request] Extensible searchEngine(s) #416

maybe-hello-world opened this issue Nov 5, 2024 · 3 comments

Comments

@maybe-hello-world
Copy link

maybe-hello-world commented Nov 5, 2024

Is your feature request related to a problem? Please describe.
I would love to be able to attach other search targets (not only my vault) to omnisearch, e.g. gDrive docs, so I can look for info in documents shared with me.

Describe the solution you'd like
Currently, there exists only one searchEngine which is hardcoded in the plugin. I'd love to be able to attach multiple search engines so the search would go over all of them. Their implementation might be different, i.e. not always implement cache but rely on other services.

Describe alternatives you've considered
Use gdrive website ☹️

Additional context
I implemented a dummy searchengine for gdrive and it seems like it might work, but currently, the only way for it is to completely rewrite the current engine. If I missed some existing options to attach other engines, (or it might be implemented in a different and better way) I'd appreciate it if you mention them.
image

@scambier
Copy link
Owner

scambier commented Nov 6, 2024

I'm not sure to understand the request. You want Omnisearch to use additional sources like your gdrive folder?

It's an Obsidian plugin, so it works in the context of Obsidian. Anything more than that would be greatly out of scope.

@maybe-hello-world
Copy link
Author

Yes, I mean implementing additional possible sources besides just the vault (more like the ability to implement them).
If you feel it doesn't fit into the plugin, this FR can be closed.

@scambier
Copy link
Owner

scambier commented Nov 7, 2024

Ok I understand. That would be too much out of scope for Omnisearch itself, but that's a good use-case for another "Text Extractor"-like plugin. The changes in Omnisearch would be minimal (just another set of calls to a 3rd party plugin or application)

For reference, see how it's done from here with Text Extractor. Your request would work a bit differently since the files are not in the vault, but ultimately, it would just be feeding data into Omnisearch.

@scambier scambier closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants