Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Issues with cm-chs-patch? #394

Closed
jiajiala opened this issue Sep 17, 2024 · 4 comments
Closed

[Bug] Issues with cm-chs-patch? #394

jiajiala opened this issue Sep 17, 2024 · 4 comments

Comments

@jiajiala
Copy link

I tried to install the recommended Chinese plugin
Word Splitting for Simplified Chinese in Edit Mode and Vim Mode

As a result of the test, the search results of the installation actually deteriorated
It is a mistake to recommend Chinese users to install this additional supplement
It made me miss Omnisearch many times
I always thought that Omnisearch's support for Chinese was not good, so my search was incomplete
However, this extra word segmentation plugin is actually the cause

If I hadn't caught this error, I still wouldn't be able to use Omnisearch

Thank you for making this excellent plugin

@scambier
Copy link
Owner

🤷‍♂️ Honestly I don't really have any opinion here as I've only done a few limited tests, and Chinese users seemed to be ok with this plugin.

Can I suggest you to poll other users (maybe on Obsidian's Discord server?) so they can give feedback here? If the plugin causes issues, I'll update the Readme accordingly.

(cc @aidenlx if you don't mind)

@jiajiala
Copy link
Author

@scambier
After testing
Word Splitting for Simplified Chinese in Edit Mode and Vim Mode will improve some problems, but it will also create other problems
I wonder if omnisearch can use the same search algorithm as obsidian's default
The default algorithm has good support for Chinese

@jiajiala jiajiala changed the title [BUG]Chinese users should not be recommended to use Word Splitting for Simplified Chinese in Edit Mode and Vim Mode, which is worse than the actual installation [BUG]f omnisearch can use the same search algorithm as obsidian's default Sep 17, 2024
@jiajiala jiajiala changed the title [BUG]f omnisearch can use the same search algorithm as obsidian's default if omnisearch can use the same search algorithm as obsidian's default Sep 17, 2024
@jiajiala jiajiala changed the title if omnisearch can use the same search algorithm as obsidian's default [Feature request] if omnisearch can use the same search algorithm as obsidian's default Sep 17, 2024
@scambier
Copy link
Owner

I wonder if omnisearch can use the same search algorithm as obsidian's default

Nope, totally different algorithms.

@scambier scambier changed the title [Feature request] if omnisearch can use the same search algorithm as obsidian's default [Bug] Issues with cm-chs-patch? Sep 18, 2024
Repository owner deleted a comment Oct 24, 2024
@scambier
Copy link
Owner

scambier commented Dec 2, 2024

Closing this issue, as I don't have enough knowledge or information to act on it.

@scambier scambier closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@scambier @jiajiala and others