Merge pull request #160 from scalprum/remove-hook-result-undefined

fix(react-core): set loading flag on remote hook render

Author: Hyperkid123

packages/react-core/src/remote-hook-provider.tsx

@@ -50,7 +50,8 @@ function HookExecutor({
 
   // Update state with the result
   useEffect(() => {
-    updateState(id, { hookResult });
+    // always set loading to false when we have a result
+    updateState(id, { loading: false, hookResult });
   }, [hookResult, id, updateState]);
 
   return null;

packages/react-core/src/use-remote-hook.ts

@@ -32,7 +32,6 @@ export const useRemoteHook = <T>({
 
         // Only update if component is still mounted
         if (isMounted) {
-          updateState(id, { loading: false, error: null });
           updateArgs(id, args); // Set args before registering hook
           registerHook(id, hookFunction);
         }