Skip to content

Commit a529cb6

Browse files
authored
chore(serverless_jobs): rename id to job_definition_id and id to job_run_id (#3518)
1 parent 7c57be1 commit a529cb6

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ require (
2424
github.com/moby/buildkit v0.11.6
2525
github.com/opencontainers/go-digest v1.0.0
2626
github.com/pkg/errors v0.9.1
27-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231121104036-359c065b044a
27+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231124161744-cd76ffab43fb
2828
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
2929
github.com/spf13/cobra v1.8.0
3030
github.com/spf13/pflag v1.0.5

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -490,8 +490,8 @@ github.com/rogpeppe/go-internal v1.11.0 h1:cWPaGQEPrBb5/AsnsZesgZZ9yb1OQ+GOISoDN
490490
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
491491
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
492492
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
493-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231121104036-359c065b044a h1:AekI2JQPYxW6UUM2bWOVg9jCWnRLdHYLxkdzgqpt1Qk=
494-
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231121104036-359c065b044a/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
493+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231124161744-cd76ffab43fb h1:2pthrdJYF/LhWQAQQ44w0QVVfSwyGg6AagyUy+pOUP8=
494+
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.21.0.20231124161744-cd76ffab43fb/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
495495
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
496496
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
497497
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=

internal/namespaces/jobs/v1alpha1/jobs_cli.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ func jobsDefinitionGet() *core.Command {
143143
ArgsType: reflect.TypeOf(jobs.GetJobDefinitionRequest{}),
144144
ArgSpecs: core.ArgSpecs{
145145
{
146-
Name: "id",
146+
Name: "job-definition-id",
147147
Required: true,
148148
Deprecated: false,
149149
Positional: true,
@@ -217,7 +217,7 @@ func jobsDefinitionUpdate() *core.Command {
217217
ArgsType: reflect.TypeOf(jobs.UpdateJobDefinitionRequest{}),
218218
ArgSpecs: core.ArgSpecs{
219219
{
220-
Name: "id",
220+
Name: "job-definition-id",
221221
Required: true,
222222
Deprecated: false,
223223
Positional: true,
@@ -294,7 +294,7 @@ func jobsDefinitionDelete() *core.Command {
294294
ArgsType: reflect.TypeOf(jobs.DeleteJobDefinitionRequest{}),
295295
ArgSpecs: core.ArgSpecs{
296296
{
297-
Name: "id",
297+
Name: "job-definition-id",
298298
Required: true,
299299
Deprecated: false,
300300
Positional: true,
@@ -329,7 +329,7 @@ func jobsDefinitionStart() *core.Command {
329329
ArgsType: reflect.TypeOf(jobs.StartJobDefinitionRequest{}),
330330
ArgSpecs: core.ArgSpecs{
331331
{
332-
Name: "id",
332+
Name: "job-definition-id",
333333
Required: true,
334334
Deprecated: false,
335335
Positional: true,
@@ -358,7 +358,7 @@ func jobsRunGet() *core.Command {
358358
ArgsType: reflect.TypeOf(jobs.GetJobRunRequest{}),
359359
ArgSpecs: core.ArgSpecs{
360360
{
361-
Name: "id",
361+
Name: "job-run-id",
362362
Required: true,
363363
Deprecated: false,
364364
Positional: true,
@@ -387,7 +387,7 @@ func jobsRunStop() *core.Command {
387387
ArgsType: reflect.TypeOf(jobs.StopJobRunRequest{}),
388388
ArgSpecs: core.ArgSpecs{
389389
{
390-
Name: "id",
390+
Name: "job-run-id",
391391
Required: true,
392392
Deprecated: false,
393393
Positional: true,
@@ -423,7 +423,7 @@ func jobsRunList() *core.Command {
423423
EnumValues: []string{"created_at_asc", "created_at_desc"},
424424
},
425425
{
426-
Name: "id",
426+
Name: "job-definition-id",
427427
Required: false,
428428
Deprecated: false,
429429
Positional: false,

0 commit comments

Comments
 (0)