Skip to content

Commit 31ad659

Browse files
Apply suggestions from code review
Co-authored-by: Benedikt Rollik <[email protected]>
1 parent 87cf91e commit 31ad659

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

serverless/containers/how-to/add-trigger-to-a-container.mdx

+2-2
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ The configuration of the queue retention can affect the behavior of the trigger.
5656
When a message is pushed to the selected queues, the container will be triggered with the message content passed in the event object's body.
5757

5858
<Message type="note">
59-
**Retry Policy:** if the Container returns a status code >= 3XX it will send the message again up to 3 times.
59+
**Retry Policy:** If the Container returns a status code >=3XX, sending the message will be retried up to three times.
6060
</Message>
6161

6262
## NATS triggers
@@ -74,7 +74,7 @@ When a message is pushed to the selected queues, the container will be triggered
7474
7. Click **Create trigger** to launch the trigger creation.
7575

7676
<Message type="note">
77-
**Retry Policy:** if the Container returns a status code >= 3XX it will send the message again up to 3 times.
77+
**Retry Policy:** If the Container returns a status code >=3XX, sending the message will be retried up to three times.
7878
</Message>
7979

8080
## CRON triggers

serverless/containers/troubleshooting/502-error-when-scaling.mdx

+7-7
Original file line numberDiff line numberDiff line change
@@ -15,21 +15,21 @@ categories:
1515

1616
## Problem
1717

18-
In some cases 502 errors can occur on Serverless Containers during autoscaling process: when the system creates new instances of the Container.
18+
502 errors can sometimes occur on Serverless Containers during the autoscaling process when new container instances are being created.
1919

2020
### Cause
2121

22-
When the new instance is created, Serverless healthcheck verification is by default done on the HTTP port. Once it's opened, the ressource is considered ready and traffic starts to be forwarded to it.
22+
When a new instance is created, the Serverless health check verification is performed by default on the HTTP port. Once the port is opened, the resource is considered ready, and traffic starts being forwarded to it.
2323

24-
This is commonly due to the traffic being sent too early to the newly created Container.
24+
This issue typically occurs when traffic is sent too early to the newly created container before it is fully deployed.
2525

2626
### Possible solutions
2727

28-
To ensure the Serverless Container is completly ready, not only the HTTP port opened but also in the software scope the solution is to use **custom healthchecks**.
28+
To ensure the Serverless Container is completely ready, both in terms of the HTTP port and the software scope, it is recommended to use **custom health checks**.
2929

30-
**Custom healthchecks** are available via the API, in this case it's recommended to implement a custom http route on the Container that returns the readiness status.
30+
**Custom health checks** can be configured via the API; in this case, it's recommended to implement a custom HTTP route on the Container that returns its readiness status.
3131

32-
* [Link to API documentation](https://www.scaleway.com/en/developers/api/serverless-containers/#path-containers-update-an-existing-container): look for `health_check`.
32+
* [API Documentation for custom health checks](https://www.scaleway.com/en/developers/api/serverless-containers/#path-containers-update-an-existing-container) - Refer to the `health_check` parameter.
3333

3434
<Message type="tip">
3535
A simple health check to implement is just a simple `GET` on `/` to make sure the HTTP server is properly listening.
@@ -45,5 +45,5 @@ To ensure the Serverless Container is completly ready, not only the HTTP port op
4545
</Message>
4646

4747
<Message type="note">
48-
Custom healthcheck feature will be available in the Scaleway console for Q1 2025.
48+
The custom health check feature will be available in the Scaleway console in Q1 2025.
4949
</Message>

serverless/functions/how-to/add-trigger-to-a-function.mdx

+2-2
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ The configuration of the queue retention may affect the behavior of the trigger.
5454
7. Click **Create trigger** to launch trigger creation.
5555

5656
<Message type="note">
57-
**Retry Policy:** if the Function returns a status code >= 3XX it will send the message again up to 3 times.
57+
**Retry Policy:** If the Function returns a status code >=3XX, sending the message will be retried up to three times.
5858
</Message>
5959

6060
## NATS triggers
@@ -72,7 +72,7 @@ Scaleway [NATS subjects](/serverless/messaging/quickstart/#quickstart-for-nats)
7272
7. Click **Create trigger** to launch trigger creation.
7373

7474
<Message type="note">
75-
**Retry Policy:** if the Function returns a status code >= 3XX it will send the message again up to 3 times.
75+
**Retry Policy:** If the Function returns a status code >=3XX, sending the message will be retried up to three times.
7676
</Message>
7777

7878
## CRON triggers

0 commit comments

Comments
 (0)