Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming an object symbol does not affect end markers #7246

Closed
odersky opened this issue Feb 24, 2025 · 4 comments · Fixed by scala/scala3#22798
Closed

Renaming an object symbol does not affect end markers #7246

odersky opened this issue Feb 24, 2025 · 4 comments · Fixed by scala/scala3#22798
Labels
bug Something that is making a piece of functionality unusable presentation-compiler Something relating to the presentation compiler Scala 3 Generic ticket relating to Scala 3 spree

Comments

@odersky
Copy link
Collaborator

odersky commented Feb 24, 2025

Rename foo to bar in

    object foo:
       def x = 1
    end foo

You get:

    object bar:
       def x = 1
    end foo

The end marker is not renamed. Renaming does work for def foo, but not for object foo.

Expected behaviour:

End markers should be renamed in all cases

Operating system:
Mac OS X

Java version:
17.0.13

Editor/extension:
Visual Studio Code v1.97.1

Metals version:
1.4.2

Extra context or search terms:

Workspace information:

  • Scala versions: 3.6.4-RC1; 2.12.20; 2.13.16
  • Build tools: 0. sbt
  • Build servers:
    0. sbt v1.10.5
  • All build tools in workspace: Bloop; sbt
@kasiaMarek
Copy link
Member

Happens only for local definitions of object. Reproduction:

def bar = 
  object foo:
    def aaa = ???
  end foo
  1

Also semantic token for object's end marker seems to be missing, since it is not correctly highlighted:

Image

@kasiaMarek kasiaMarek added bug Something that is making a piece of functionality unusable Scala 3 Generic ticket relating to Scala 3 presentation-compiler Something relating to the presentation compiler labels Feb 25, 2025
@odersky
Copy link
Collaborator Author

odersky commented Feb 25, 2025

Maybe it's because local definitions are expanded by desugaring to lazy vals and module classes?

@kasiaMarek
Copy link
Member

My bet would be that rename for local definitions goes through a simplified flow, where it is entirely handled by presentation compiler on that single file, and there we forget to "collect" that end marker. I think that the same "collector" is used for semantic tokens, so it explains the missing highlight:

Image

@kasiaMarek
Copy link
Member

The issue should be probably fixed somewhere in https://github.com/scala/scala3/blob/main/presentation-compiler/src/main/dotty/tools/pc/PcCollector.scala.

Tests can be added to https://github.com/scala/scala3/blob/main/presentation-compiler/test/dotty/tools/pc/tests/edit/PcRenameSuite.scala and https://github.com/scala/scala3/blob/main/presentation-compiler/test/dotty/tools/pc/tests/tokens/SemanticTokensSuite.scala.

@natsukagami natsukagami mentioned this issue Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that is making a piece of functionality unusable presentation-compiler Something relating to the presentation compiler Scala 3 Generic ticket relating to Scala 3 spree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore ending $ when looking at end marker names natsukagami/dotty
2 participants
@odersky @kasiaMarek