Test source compiled twice

Test that an error message is issued for sources in different directories
but with the same filename and package.

Also: Drop out-of-date ErrorMessageTest

Author: odersky

compiler/test/dotty/tools/dotc/CompilationTests.scala

@@ -165,7 +165,11 @@ class CompilationTests extends ParallelTesting {
     compileFile("tests/neg-custom-args/i3627.scala", allowDeepSubtypes) +
     compileFile("tests/neg-custom-args/matchtype-loop.scala", allowDeepSubtypes) +
     compileFile("tests/neg-custom-args/completeFromSource/nested/Test1.scala", defaultOptions.and("-sourcepath", "tests/neg-custom-args", "-scansource")) +
-    compileFile("tests/neg-custom-args/repeatedArgs213.scala", defaultOptions.and("-Ynew-collections"))
+    compileFile("tests/neg-custom-args/repeatedArgs213.scala", defaultOptions.and("-Ynew-collections")) +
+    compileList("duplicate source", List(
+      "tests/neg-custom-args/toplevel-samesource/S.scala",
+      "tests/neg-custom-args/toplevel-samesource/nested/S.scala"),
+      defaultOptions)
   }.checkExpectedErrors()
 
   @Test def fuzzyAll: Unit = {

compiler/test/dotty/tools/dotc/reporting/ErrorMessagesTests.scala

@@ -705,20 +705,6 @@ class ErrorMessagesTests extends ErrorMessagesTest {
       assertEquals("final", flags.toString)
     }
 
-  @Test def topLevelCantBeImplicit =
-    checkMessagesAfter(FrontEnd.name) {
-      """package Foo {
-        |  implicit object S
-        |}
-        |""".stripMargin
-    }
-    .expect { (ictx, messages) =>
-      implicit val ctx: Context = ictx
-      assertMessageCount(1, messages)
-      val TopLevelCantBeImplicit(symbol) :: Nil = messages
-      assertEquals("object S", symbol.show)
-    }
-
   @Test def typesAndTraitsCantBeImplicit =
     checkMessagesAfter(FrontEnd.name) {
       """class Foo {

tests/neg-custom-args/toplevel-samesource/S.scala

@@ -0,0 +1,2 @@
+package p
+val a = 1

tests/neg-custom-args/toplevel-samesource/nested/S.scala

@@ -0,0 +1,2 @@
+package p
+val b = 2 // error: package object S$package in package p has already been compiled once during this run