-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK9 swing generification changes #15
Comments
There is only one line of change to make to get a clean compile. Slider.scala line 61 changes from The compilation was performed with sbt 0.13.5, scala 2.11.2, and JDK 1.9.0-ea-b27. |
I forgot to mention the branch I used: java7. The one line change is backwards compatible with JDK 1.7.0_51, so a separate java9 branch is overkill. |
Hi Allan I'll do the change in the next couple of days, (or please create a pull On 2 September 2014 00:31, Allan Jacobs [email protected] wrote:
|
Hi Andy, Have you taken over the job of maintaining the module? There is a page On 09/02/2014 11:53 AM, Andy Hicks wrote:
|
Hi Allen Yes, I've been given commit access to scala-swing and given some spare time As for, "will it be in 2.12"? That's still open, I think it will depend Andy On 6 September 2014 17:32, Allan Jacobs [email protected] wrote:
|
Hi Andy, I have converted the majority of the Swing demos at The conversion is deliberately close to the Java (a) so that the Allan On 09/07/2014 05:17 AM, Andy Hicks wrote:
|
Hi Allan That sounds really great :-) If you havent done so, can you 'sign' the Scala CLA I would suggest adding them to the folder Andy On 19 September 2014 16:39, Allan Jacobs [email protected] wrote:
|
Hi Andy, Under examples/src/main/scala/scala/swing/examples I've created a Below the "tutorials" directory, I would like to preserve some directory I've only converted a subset of the "components" tutorials. These all Another issue: What do you want to do with demos that should work but Examples: (1) "TableSortDemo" displays a table that is supposed to have Allan $ ls -lR examples/src/main/scala/scala/swing/examples/tutorials examples/src/main/scala/scala/swing/examples/tutorials/java: examples/src/main/scala/scala/swing/examples/tutorials/java/components: examples/src/main/scala/scala/swing/examples/tutorials/resources: examples/src/main/scala/scala/swing/examples/tutorials/resources/arnold_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/bloch_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/chan_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/images: examples/src/main/scala/scala/swing/examples/tutorials/resources/images/doggy: examples/src/main/scala/scala/swing/examples/tutorials/resources/images/geek: examples/src/main/scala/scala/swing/examples/tutorials/resources/images/Styled examples/src/main/scala/scala/swing/examples/tutorials/resources/images/tumble: examples/src/main/scala/scala/swing/examples/tutorials/resources/jls_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/Styled examples/src/main/scala/scala/swing/examples/tutorials/resources/swingtutorial_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/TreeDemoHelp_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/tutorialcont_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/tutorial_files: examples/src/main/scala/scala/swing/examples/tutorials/resources/vm_files: examples/src/main/scala/scala/swing/examples/tutorials/scala: examples/src/main/scala/scala/swing/examples/tutorials/scala/components: On 09/21/2014 10:27 AM, Andy Hicks wrote:
|
IANAL, but but doesn't seem to me that the Java Swing demo's are suitably licensed for us to include a derivative work with Scala. WDYT? |
Why? It's basically a BSD-style license. In any case, neither source nor binary should go into For reasons of clarity and simplicity, I would not include Java files. From your list, it looks like you have only one file. Better convert it to a Scala equivalent. |
You are right, I didn't read the "with or without modification" part. So long as we retain the Oracle copyright in addition to the standard Scala copyright, things should be okay. |
In the IANAL sections - ya we should keep a copy of the Oracle copyright I'm cant find a github repo with the code yet so this is a little
If you create a fork with the code in I'm more than happy to help On 22 September 2014 06:52, Jason Zaugg [email protected] wrote:
|
@Sciss should this ticket remain open? |
With respect to the ticket's title; I can cross compile under JDK 11, so I would assume that there are no pending necessary changes regarding generification. In that sense I guess the ticket can be closed. I would like to ask @jacobsallan if you are still interested in contributing your tutorials. That should go into a separate PR, however. I can see that you have extra branches in your fork; you could try to rebase them if necessary. There is an open ticket #68 regarding contributions, but last status was that it's still advisable to have the CLA signed. Perhaps @SethTisue could help identifying how to proceed there. I'm closing this issue now, so please for the tutorials open a new one or submit the PR directly. |
Joseph Darcy (@jddarcy) has tweeted ( https://twitter.com/jddarcy/status/493137546814042112 )
Swing developers, please recompile your apps with JDK 9 build 24 to test the compatibility of recent swing generification changes.
Guess this will need another branch (based on java7) with more changes.
The text was updated successfully, but these errors were encountered: