Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken 0.2.0 artifact (no .class files in .jar) #51

Closed
linasm opened this issue Sep 17, 2019 · 9 comments · Fixed by #72
Closed

Broken 0.2.0 artifact (no .class files in .jar) #51

linasm opened this issue Sep 17, 2019 · 9 comments · Fixed by #72
Assignees
@SethTisue

Comments

@linasm
Copy link
Contributor

linasm commented Sep 17, 2019

scala-collection-contrib_2.13-0.2.0.jar is missing .class files (it only has .properties file and manifest)

https://repo1.maven.org/maven2/org/scala-lang/modules/scala-collection-contrib_2.13/0.2.0/scala-collection-contrib_2.13-0.2.0.jar

@SethTisue @julienrf
@SethTisue SethTisue self-assigned this Sep 17, 2019
@harpocrates
Copy link

Just hit this too...

julienrf added a commit that referenced this issue Oct 28, 2019
@julienrf
Move the collectionContrib project to a collection-contrib subdirectory
142cde4 
This is a tentative to address #51

At least now, the `package` task builds a .jar file that contains .class files. The `publishLocal` task, however, still does not build a .jar file containing the .class files.

I’ve noticed that `collectionContribJS/publishLocal` builds a correct .jar file. The only difference between the JS and JVM projects is that the JVM project applies the `scalaModuleSettingsJVM` settings, which does something with sbt-osgi, which I didn’t dig into…
@julienrf julienrf mentioned this issue Oct 28, 2019
Closed
mpollmeier added a commit to mpollmeier/scala-collection-contrib that referenced this issue Nov 25, 2019
@mpollmeier
drop javascript to fix publishing of jar
e43719f 
addresses scala#51

other attempt doesn't fully work, see scala#63 (comment)
mpollmeier added a commit to mpollmeier/scala-collection-contrib that referenced this issue Nov 25, 2019
@mpollmeier
drop javascript to fix publishing of jar
3fc2353 
addresses scala#51

other attempt doesn't fully work, see scala#63 (comment)
@mpollmeier
Copy link

mpollmeier commented Nov 25, 2019 •
edited
Loading

While we're waiting for a usable artifact I published a jar to my bintray. If anyone else wants to use it:

libraryDependencies += "com.michaelpollmeier" %% "scala-collection-contrib" % "0.2.1"
resolvers += Resolver.bintrayRepo("mpollmeier", "maven")

https://github.com/mpollmeier/scala-collection-contrib/releases/tag/v0.2.1
(I simply ripped out scalajs from the build).

@skradel
Copy link

skradel commented Nov 25, 2019

Ditto, the (essentially empty) artifact gave rise to a certain amount of head-scratching; using 0.1.0 for the time being to quiet MultiMap deprecation warnings.

@pioorg pioorg mentioned this issue Nov 27, 2019
Closed
@SethTisue
Copy link
Member

this is an OSGi / sbt-osgi problem. it's similar to scala/community-build#981 and scala/scala-parallel-collections#5

@SethTisue
Copy link
Member

one thing we might consider here is whether this stuff ought to be under scala.collection (or any other scala. subpackage) at all

@SethTisue
Copy link
Member

another possibility is to just disable the OSGi stuff in this repo, and document it as a limitation that we'd welcome community help with but don't plan to tackle ourselves (the core Scala team). Adriaan has already said he's fine with that (and there wasn't any dissent within the team)

I'll poke at sbt-osgi and sbt-scala-module and see what I think that would involve

@SethTisue SethTisue mentioned this issue Dec 22, 2019
Open
SethTisue added a commit to SethTisue/scala-collection-contrib that referenced this issue Dec 22, 2019
@SethTisue
fix bad artifacts by disabling OSGi support
b5b7d0c 
fixes scala#51
@SethTisue SethTisue mentioned this issue Dec 22, 2019
Merged
@SethTisue
Copy link
Member

another possibility is to just disable the OSGi stuff in this repo

yeah, let's do that, it turned out to be relatively easy

PR with fix: #72
issue to document lack of OSGi support: #71

unless there are objections, I'll merge the PR and publish after Christmas

SethTisue added a commit to SethTisue/scala-collection-contrib that referenced this issue Dec 22, 2019
@SethTisue
fix bad artifacts by disabling OSGi support
fd48f87 
fixes scala#51
@SethTisue SethTisue reopened this Dec 30, 2019
@SethTisue
Copy link
Member

PR merged. next: publishing

@SethTisue
Copy link
Member

SethTisue commented Dec 30, 2019 •
edited
Loading

julienrf added a commit that referenced this issue Jan 1, 2020
@julienrf
Move the collectionContrib project to a collection-contrib subdirectory
9a82a44 
This is a tentative to address #51

At least now, the `package` task builds a .jar file that contains .class files. The `publishLocal` task, however, still does not build a .jar file containing the .class files.

I’ve noticed that `collectionContribJS/publishLocal` builds a correct .jar file. The only difference between the JS and JVM projects is that the JVM project applies the `scalaModuleSettingsJVM` settings, which does something with sbt-osgi, which I didn’t dig into…
@SethTisue SethTisue mentioned this issue Feb 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bad artifacts by disabling OSGi support SethTisue/scala-collection-contrib
5 participants
@skradel @SethTisue @mpollmeier @linasm @harpocrates