Completions not working in templates with errors & other situations

[dragos]

Completions don't work at the end of a @ section, or with unmatched braces:

@(message: String, user: User)

@main("Welcome to Play 2.1") {
  <p>My name is: @{user.}</p>
  <p>@user.</p> // no completion at all
  @user. // Scope completion instead of member completion

There are several causes:

• the partitioner makes an off-by-one mistake (adding a space before the closing tag fixes it)
• the template compiler throws exceptions for syntax errors
• the logic for selecting scope-completion over member completion misfires

[aldenml]

I want to share my findings about this issue. Even when the template is correct, a line like this

@user.

does not get completion at all due to the way the "virtual code" is created. The ScalaTemplateCompiler parser generates ScalaExpr(user) + """.

""" preventing the dot character from triggering the ContentAssistProcessor logic.

I can confirm that using Play2, a complete template like the one posted in the issue renders

user = "test"
@user. -----> test. (note the final dot, only @user is parsed like a scala expr)
@user.toUpperCase ------------> TEST (now its completely parsed like a scala expr)

[dragos]

@aldenml, thanks for detailing this. It looks like a "feature" of the template compiler (and one more reason to have our own in the IDE).