Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary usage of Option and get in route formatter #113

Open
skyluc opened this issue May 2, 2013 · 0 comments
Open

Unnecessary usage of Option and get in route formatter #113

skyluc opened this issue May 2, 2013 · 0 comments
Labels
formatting needs-attention

Comments

@skyluc
Copy link
Member

skyluc commented May 2, 2013

The route formatter is extracting line information from the partitions using Option, Option.get() and iteration.
I don't think the Option are needed, and it should be possible to have a less mutable solution.

The code is in format() and and getRoutes().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
formatting needs-attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skyluc