Skip to content

Commit f1362b2

Browse files
authored
Merge pull request scalacenter#1954 from scalacenter/sbtCleanup
refactor: get rid of leftover integration utils
2 parents a20f710 + e3f3ed6 commit f1362b2

File tree

5 files changed

+12
-294
lines changed

5 files changed

+12
-294
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ jobs:
3737
- name: Tests
3838
run: |
3939
./bin/sbt-ci.sh \
40-
"sbtBloop10/publishLocal" \
41-
"sbtBloop10/scripted"
40+
"sbtBloop/publishLocal" \
41+
"sbtBloop/scripted"
4242
shell: bash
4343
bridges:
4444
name: Test platform bridges

build.sbt

Lines changed: 7 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,7 @@ lazy val bloopShared = (project in file("shared"))
8989
* ************************************************************************************************
9090
*/
9191
import build.Dependencies
92-
import build.Dependencies.{
93-
Scala210Version,
94-
Scala211Version,
95-
Scala212Version,
96-
Sbt013Version,
97-
Sbt1Version
98-
}
92+
import build.Dependencies.{Scala210Version, Scala211Version, Scala212Version, SbtVersion}
9993

10094
lazy val backend = project
10195
.enablePlugins(BuildInfoPlugin)
@@ -477,46 +471,13 @@ def isJdiJar(file: File): Boolean = {
477471
else file.getAbsolutePath.contains(SbtJdiTools.JavaTools.getAbsolutePath.toString)
478472
}
479473

480-
lazy val integrationUtils211 = project
481-
.in(integrations / "utils")
482-
.settings(
483-
scalafixSettings,
484-
scalaVersion := Dependencies.Scala211Version,
485-
libraryDependencies += Dependencies.bloopConfig,
486-
target := (file(
487-
"integrations"
488-
) / "utils" / "target" / "utils-2.11").getAbsoluteFile
489-
)
490-
491-
lazy val integrationUtils212 = project
492-
.in(integrations / "utils")
493-
.settings(
494-
scalafixSettings,
495-
scalaVersion := Dependencies.Scala212Version,
496-
libraryDependencies += Dependencies.bloopConfig,
497-
target := (file(
498-
"integrations"
499-
) / "utils" / "target" / "utils-2.12").getAbsoluteFile
500-
)
501-
502-
lazy val integrationUtils213 = project
503-
.in(integrations / "utils")
504-
.settings(
505-
scalafixSettings,
506-
scalaVersion := Dependencies.Scala213Version,
507-
libraryDependencies += Dependencies.bloopConfig,
508-
target := (file(
509-
"integrations"
510-
) / "utils" / "target" / "utils-2.13").getAbsoluteFile
511-
)
512-
513-
lazy val sbtBloop10: Project = project
474+
lazy val sbtBloop: Project = project
514475
.enablePlugins(ScriptedPlugin)
515476
.disablePlugins(ScalafixPlugin)
516477
.in(integrations / "sbt-bloop")
517478
.settings(
518479
BuildDefaults.scriptedSettings,
519-
sbtPluginSettings("sbt-bloop", Sbt1Version),
480+
sbtPluginSettings("sbt-bloop", SbtVersion),
520481
libraryDependencies += Dependencies.bloopConfig
521482
)
522483

@@ -626,7 +587,7 @@ val allProjects = Seq(
626587
backend,
627588
frontend,
628589
benchmarks,
629-
sbtBloop10,
590+
sbtBloop,
630591
nativeBridge04,
631592
jsBridge06,
632593
jsBridge1,
@@ -635,17 +596,14 @@ val allProjects = Seq(
635596
launcherTest,
636597
sockets,
637598
bloopgun,
638-
bloopgun213,
639-
integrationUtils211,
640-
integrationUtils212,
641-
integrationUtils213
599+
bloopgun213
642600
)
643601

644602
val allProjectsToRelease = Seq[ProjectReference](
645603
bloopShared,
646604
backend,
647605
frontend,
648-
sbtBloop10,
606+
sbtBloop,
649607
nativeBridge04,
650608
jsBridge06,
651609
jsBridge1,
@@ -670,7 +628,6 @@ val bloop = project
670628
.settings(
671629
releaseEarly := { () },
672630
(publish / skip) := true,
673-
crossSbtVersions := Seq(Sbt1Version, Sbt013Version),
674631
buildIntegrationsBase := (ThisBuild / Keys.baseDirectory).value / "build-integrations",
675632
publishLocalAllModules := {
676633
BuildDefaults
@@ -694,7 +651,7 @@ val bloop = project
694651
build.BuildImplementation
695652
.exportCommunityBuild(
696653
buildpress,
697-
sbtBloop10
654+
sbtBloop
698655
)
699656
.value
700657
}

integrations/utils/src/main/scala/bloop/integrations/utils/BaseConfigSuite.scala

Lines changed: 0 additions & 238 deletions
This file was deleted.

project/BuildPlugin.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,7 +522,7 @@ object BuildImplementation {
522522
val buildpressHomePath = System.getProperty("user.home") + "/.buildpress"
523523
def exportCommunityBuild(
524524
buildpress: Reference,
525-
sbtBloop10: Reference
525+
sbtBloop: Reference
526526
) = Def.taskDyn {
527527
val isWindows: Boolean =
528528
System.getProperty("os.name").toLowerCase(Locale.ENGLISH).contains("windows")
@@ -540,7 +540,7 @@ object BuildImplementation {
540540
val bloopVersion = Keys.version.value
541541
Def.task {
542542
// Publish the projects before we invoke buildpress
543-
(sbtBloop10 / Keys.publishLocal).value
543+
(sbtBloop / Keys.publishLocal).value
544544

545545
val file = Keys.resourceDirectory
546546
.in(Compile)

project/Dependencies.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ object Dependencies {
66
val Scala212Version = "2.12.17"
77
val Scala213Version = "2.13.8"
88

9-
val Sbt013Version = "0.13.18"
10-
val Sbt1Version = "1.3.3"
9+
val SbtVersion = "1.3.3"
1110

1211
val nailgunVersion = "ee3c4343"
1312
// Used to download the python client instead of resolving

0 commit comments

Comments
 (0)