Update Perf Issue count to match bg tracing window (facebook#54387)

Summary:
Pull Request resolved: facebook#54387

Changelog: [Internal]

Reviewed By: sbuggay

Differential Revision: D86107869

fbshipit-source-id: dfaf224557158616918a5c89080e7c8802ec1d35

Author: huntie

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt

@@ -7,6 +7,8 @@
 
 package com.facebook.react.devsupport.perfmonitor
 
+import android.os.Handler
+import android.os.Looper
 import com.facebook.react.bridge.UiThreadUtil
 import com.facebook.react.devsupport.interfaces.TracingState
 
@@ -23,6 +25,7 @@ internal class PerfMonitorOverlayManager(
   private var view: PerfMonitorOverlayView? = null
   private var tracingState: TracingState = TracingState.ENABLEDINCDPMODE
   private var perfIssueCount: Int = 0
+  private val handler = Handler(Looper.getMainLooper())
 
   /** Enable the Perf Monitor overlay. */
   fun enable() {
@@ -75,6 +78,7 @@ internal class PerfMonitorOverlayManager(
     tracingState = state
     if (state != TracingState.DISABLED) {
       perfIssueCount = 0
+      handler.removeCallbacksAndMessages(null)
     }
     UiThreadUtil.runOnUiThread {
       view?.updateRecordingState(state)
@@ -84,10 +88,23 @@ internal class PerfMonitorOverlayManager(
   }
 
   override fun onPerfIssueAdded(name: String) {
+    perfIssueCount++
+
     UiThreadUtil.runOnUiThread {
-      view?.updatePerfIssueCount(++perfIssueCount)
+      view?.updatePerfIssueCount(perfIssueCount)
       view?.show()
     }
+
+    handler.postDelayed(
+        {
+          perfIssueCount--
+          UiThreadUtil.runOnUiThread {
+            view?.updatePerfIssueCount(perfIssueCount)
+            view?.show()
+          }
+        },
+        PERF_ISSUE_EXPIRY_MS,
+    )
   }
 
   private fun handleRecordingButtonPress() {
@@ -105,4 +122,8 @@ internal class PerfMonitorOverlayManager(
       TracingState.ENABLEDINCDPMODE -> Unit
     }
   }
+
+  companion object {
+    private const val PERF_ISSUE_EXPIRY_MS = 20_000L
+  }
 }

packages/react-native/ReactCommon/jsinspector-modern/PerfMonitorV2.cpp

@@ -21,7 +21,15 @@ void PerfMonitorUpdateHandler::handlePerfIssueAdded(
     delegate_.unstable_onPerfIssueAdded(
         PerfIssuePayload{
             .name = payload["name"].asString(),
-            .severity = payload["severity"].asString(),
+            .severity = payload["severity"].isNull()
+                ? std::nullopt
+                : std::make_optional(payload["severity"].asString()),
+            .description = payload["description"].isNull()
+                ? std::nullopt
+                : std::make_optional(payload["description"].asString()),
+            .learnMoreUrl = payload["learnMoreUrl"].isNull()
+                ? std::nullopt
+                : std::make_optional(payload["learnMoreUrl"].asString()),
         });
   }
 }

packages/react-native/ReactCommon/jsinspector-modern/PerfMonitorV2.h

@@ -7,6 +7,7 @@
 
 #pragma once
 
+#include <optional>
 #include <string>
 
 namespace facebook::react::jsinspector_modern {
@@ -15,7 +16,9 @@ class HostTargetDelegate;
 
 struct PerfIssuePayload {
   std::string name;
-  std::string severity;
+  std::optional<std::string> severity;
+  std::optional<std::string> description;
+  std::optional<std::string> learnMoreUrl;
 };
 
 /**