PostgreSQL Server storage_size should be specified in GB, not MB

[oleksiisas]

Terraform Version Details

v1.9.6

Terraform Variable File Details

No response

Steps to Reproduce

Specify the storage_size value for PostgreSQL Server in megabytes (Example: 128000). See that it exceeds default AWS quotas for RDS, and that terraform is trying to create a database with the size of 128000 Gigabytes.

Expected Behavior

An RDS PostgreSQL database with max storage of 128GB should have been created.

Actual Behavior

Terraform attempts to create RDS PostgreSQL database with max storage of 128000GB, and fails due to quotas.

Additional Context

This issue is about the "storage_size" parameter for PostgreSQL (link below).

https://github.com/sassoftware/viya4-iac-aws/blob/main/docs/CONFIG-VARS.md#postgresql-server

The instruction says that it should be specified in megabytes, but when we tried to set it to "128000" earlier, we exceeded our AWS resource quota of 100000 GB. After we changed it to "128", an RDS resource with 128GB max storage was created. Hence I think that it should be specified in GB instead.

Also, if it is truly specified in megabytes, the default value of 50MB wouldn't be sufficient for Viya.

References

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[miaeyg]

I've reported this a year ago: Issue #270 and got this reply

Hi @miaeyg, thanks for noticing that and good catch. The description for the storage_size input variable should indicate that the units are in GB, not MB. I will open a ticket to fix that doc reference. Will also handle adjusting the default size if needed.

So not sure why the doc was not updated yet