Merge pull request cloudfoundry#3188 from sap-contributions/bump-rubocop

bump rubocop from 1.44.1 to 1.45.1

Author: johha

Gemfile

@@ -89,7 +89,7 @@ group :test do
   gem 'rspec-rails', '~> 6.0.1'
   gem 'rspec-wait'
   gem 'rspec_api_documentation', '>= 6.1.0'
-  gem 'rubocop', '~> 1.44.1'
+  gem 'rubocop', '~> 1.45.1'
   gem 'timecop'
   gem 'webmock', '> 2.3.1'
 end

Gemfile.lock

@@ -380,7 +380,7 @@ GEM
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     recursive-open-struct (1.1.3)
-    regexp_parser (2.6.2)
+    regexp_parser (2.7.0)
     representable (3.2.0)
       declarative (< 0.1.0)
       trailblazer-option (>= 0.1.1, < 0.2.0)
@@ -432,7 +432,7 @@ GEM
       activesupport (>= 3.0.0)
       mustache (~> 1.0, >= 0.99.4)
       rspec (~> 3.0)
-    rubocop (1.44.1)
+    rubocop (1.45.1)
       json (~> 2.3)
       parallel (~> 1.10)
       parser (>= 3.2.0.0)
@@ -605,7 +605,7 @@ DEPENDENCIES
   rspec-rails (~> 6.0.1)
   rspec-wait
   rspec_api_documentation (>= 6.1.0)
-  rubocop (~> 1.44.1)
+  rubocop (~> 1.45.1)
   rubyzip (>= 1.3.0)
   sequel (~> 5.65)
   sequel_pg

app/controllers/v3/space_features_controller.rb

@@ -16,7 +16,7 @@ def index
   def show
     space = SpaceFetcher.new.fetch(hashed_params[:guid])
     resource_not_found!(:space) unless space && permission_queryer.can_read_from_space?(space.id, space.organization_id)
-    resource_not_found!(:feature) unless SPACE_FEATURE == hashed_params[:name]
+    resource_not_found!(:feature) unless hashed_params[:name] == SPACE_FEATURE
 
     render status: :ok, json: Presenters::V3::SpaceSshFeaturePresenter.new(space)
   end
@@ -27,7 +27,7 @@ def update
 
     space = SpaceFetcher.new.fetch(hashed_params[:guid])
     resource_not_found!(:space) unless space && permission_queryer.can_read_from_space?(space.id, space.organization_id)
-    resource_not_found!(:feature) unless SPACE_FEATURE == hashed_params[:name]
+    resource_not_found!(:feature) unless hashed_params[:name] == SPACE_FEATURE
     unauthorized! unless permission_queryer.can_update_active_space?(space.id, space.organization_id)
     suspended! unless permission_queryer.is_space_active?(space.id)
 

lib/cloud_controller/diego/reporters/instances_reporter.rb

@@ -113,8 +113,8 @@ def logger
 
       def running_or_starting?(lrp)
         translated_state = LrpStateTranslator.translate_lrp_state(lrp)
-        return true if VCAP::CloudController::Diego::LRP_RUNNING == translated_state
-        return true if VCAP::CloudController::Diego::LRP_STARTING == translated_state
+        return true if translated_state == VCAP::CloudController::Diego::LRP_RUNNING
+        return true if translated_state == VCAP::CloudController::Diego::LRP_STARTING
 
         false
       end